feat: Created Course updates page #581

vladislavkeblysh · 2023-08-29T06:07:33Z

Created Course updates page
Ability to add new course update and handouts, edit, delete updates, edit handouts

openedx-webhooks · 2023-08-29T06:07:37Z

Thanks for the pull request, @vladislavkeblysh! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov · 2023-08-29T06:16:54Z

Codecov Report

Patch coverage: 85.44% and project coverage change: +0.08% 🎉

Comparison is base (181f9c7) 84.54% compared to head (ccfd55b) 84.62%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   84.54%   84.62%   +0.08%     
==========================================
  Files         279      301      +22     
  Lines        4582     4847     +265     
  Branches     1029     1072      +43     
==========================================
+ Hits         3874     4102     +228     
- Misses        684      721      +37     
  Partials       24       24

Files Changed	Coverage Δ
src/CourseAuthoringRoutes.jsx	`100.00% <ø> (ø)`
src/store.js	`100.00% <ø> (ø)`
src/course-updates/hooks.jsx	`60.00% <60.00%> (ø)`
src/course-updates/update-form/utils.js	`81.81% <81.81%> (ø)`
src/course-updates/data/thunk.js	`83.33% <83.33%> (ø)`
src/course-updates/update-form/UpdateForm.jsx	`84.21% <84.21%> (ø)`
src/course-updates/CourseUpdates.jsx	`92.59% <92.59%> (ø)`
src/constants.js	`100.00% <100.00%> (ø)`
src/course-updates/constants.js	`100.00% <100.00%> (ø)`
.../course-updates/course-handouts/CourseHandouts.jsx	`100.00% <100.00%> (ø)`
... and 15 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mphilbrick211 · 2023-08-29T12:55:07Z

Hi @openedx/teaching-and-learning! Would someone be able to please review/merge this for us? Thank you!

KristinAoki · 2023-08-29T14:35:31Z

src/generic/processing-notification/index.jsx

+  <Badge
+    className={classNames('processing-notification', {
+      'is-show': isShow,
+    })}
+    variant="secondary"
+    aria-hidden={isShow}
+  >
+    <Icon className="processing-notification-icon" src={IconSettings} />
+    <h2 className="processing-notification-title">
+      {capitalize(title)}
+    </h2>
+  </Badge>


Is there a reason you decided to use the Badge component instead of the Toast component?

We tried to replicate the behavior of the legacy as closely as possible. This component should appear on the right (while the Toast appears on the left) and should visually resemble the legacy as much as possible. Additionally, the Toast has a close button and slightly different functionality

KristinAoki · 2023-08-29T14:38:55Z

src/generic/WysiwygEditor.jsx

@@ -73,7 +73,7 @@ export const WysiwygEditor = ({
        minHeight={minHeight}
        editorContentHtml={initialValue}
        setEditorRef={setEditorRef}
-        onChange={handleUpdate}
+        updateContent={handleUpdate}


Suggested change

updateContent={handleUpdate}

onChange={handleUpdate}

This needs to be onChange. The prop has been renamed in frontend-lib-content-components because of a inherited prop conflict.

KristinAoki · 2023-08-29T14:46:06Z

src/course-updates/data/thunk.js

+      dispatch(updateSavingStatuses({ createCourseUpdateQuery: RequestStatus.PENDING }));
+      dispatch(showProcessingNotification(NOTIFICATION_MESSAGES.saving));
+      const courseHandouts = await editHandouts(courseId, data);
+      dispatch(editCourseHandouts(courseHandouts));


On edit, the api call is working as expected, but the data does not include the updates made to update. This is probably connected to the change that you made in the wysiwyg editor.

KristinAoki · 2023-08-29T14:46:13Z

src/course-updates/data/thunk.js

+      dispatch(updateSavingStatuses({ createCourseUpdateQuery: RequestStatus.PENDING }));
+      dispatch(showProcessingNotification(NOTIFICATION_MESSAGES.saving));
+      const courseUpdate = await editUpdate(courseId, data);
+      dispatch(editCourseUpdate(courseUpdate));


On edit, the api call is working as expected, but the data does not include the updates made to update. This is probably connected to the change that you made in the wysiwyg editor.

KristinAoki · 2023-08-29T14:53:28Z

src/course-updates/CourseUpdates.jsx

+          <Layout
+            lg={[{ span: 9 }, { span: 3 }]}
+            md={[{ span: 9 }, { span: 3 }]}
+            sm={[{ span: 9 }, { span: 3 }]}
+            xs={[{ span: 9 }, { span: 3 }]}
+            xl={[{ span: 9 }, { span: 3 }]}
+          >


The span should be set to 12 because there is no aside.

KristinAoki · 2023-08-29T15:00:57Z

src/course-updates/data/thunk.js

+      dispatch(updateSavingStatuses({ createCourseUpdateQuery: RequestStatus.PENDING }));
+      dispatch(showProcessingNotification(NOTIFICATION_MESSAGES.saving));
+      const courseUpdate = await createUpdate(courseId, data);
+      dispatch(createCourseUpdate(courseUpdate));


On edit, the api call is working as expected, but the data does not include the updates made to update. This is probably connected to the change that you made in the wysiwyg editor.

KristinAoki · 2023-08-30T20:36:16Z

src/course-updates/update-form/UpdateForm.jsx

+              <Button variant="tertiary" type="button" onClick={close}>
+                {intl.formatMessage(messages.cancelButton)}
+              </Button>
+              <Button onClick={handleSubmit} type="submit">


Button should be disabled if the form cannot be submitted

openedx-webhooks · 2023-08-31T14:56:48Z

@vladislavkeblysh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 29, 2023

vladislavkeblysh marked this pull request as draft August 29, 2023 06:07

feat: create Course updates page

6de029c

vladislavkeblysh force-pushed the keblysh/course-updates branch 4 times, most recently from 3861234 to 8a8d2a1 Compare August 29, 2023 08:48

fix: increase code coverage on the page

6c13a0b

vladislavkeblysh force-pushed the keblysh/course-updates branch from 516afdb to 6c13a0b Compare August 29, 2023 10:08

vladislavkeblysh marked this pull request as ready for review August 29, 2023 10:40

mphilbrick211 requested a review from a team August 29, 2023 12:54

KristinAoki requested changes Aug 29, 2023

View reviewed changes

mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 29, 2023

fix: fixed layout and wisiwyg props

138743c

mphilbrick211 removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Aug 30, 2023

KristinAoki requested changes Aug 30, 2023

View reviewed changes

fix: fixed submit button

ccfd55b

vladislavkeblysh force-pushed the keblysh/course-updates branch from bf98a00 to ccfd55b Compare August 31, 2023 09:37

KristinAoki approved these changes Aug 31, 2023

View reviewed changes

KristinAoki merged commit ffae3bd into openedx:master Aug 31, 2023
5 checks passed

snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024

feat: Created Course updates page (openedx#581)

9b12dd2

kenclary mentioned this pull request Jan 9, 2024

fix: configure webpack to fix paid powerpaste plugin #783

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Created Course updates page #581

feat: Created Course updates page #581

vladislavkeblysh commented Aug 29, 2023

openedx-webhooks commented Aug 29, 2023 •

edited

Loading

codecov bot commented Aug 29, 2023 •

edited

Loading

mphilbrick211 commented Aug 29, 2023

KristinAoki Aug 29, 2023

vladislavkeblysh Aug 30, 2023

KristinAoki Aug 29, 2023

vladislavkeblysh Aug 30, 2023

KristinAoki Aug 29, 2023

vladislavkeblysh Aug 30, 2023

KristinAoki Aug 29, 2023

vladislavkeblysh Aug 30, 2023

KristinAoki Aug 29, 2023

vladislavkeblysh Aug 30, 2023

KristinAoki Aug 29, 2023

vladislavkeblysh Aug 30, 2023

KristinAoki Aug 30, 2023

vladislavkeblysh Aug 31, 2023

openedx-webhooks commented Aug 31, 2023

feat: Created Course updates page #581

feat: Created Course updates page #581

Conversation

vladislavkeblysh commented Aug 29, 2023

openedx-webhooks commented Aug 29, 2023 • edited Loading

codecov bot commented Aug 29, 2023 • edited Loading

Codecov Report

mphilbrick211 commented Aug 29, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

openedx-webhooks commented Aug 31, 2023

openedx-webhooks commented Aug 29, 2023 •

edited

Loading

codecov bot commented Aug 29, 2023 •

edited

Loading