Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change head title depending on page #582

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

KristinAoki
Copy link
Member

JIRA Ticket: TNL-10949

This PR updates the tab title for a page to match the page title and include the course name. The new tab title pattern matches the legacy tab title pattern.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (a1793ef) 84.55% compared to head (33d5c4e) 84.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   84.55%   84.62%   +0.06%     
==========================================
  Files         307      308       +1     
  Lines        4993     5015      +22     
  Branches     1102     1103       +1     
==========================================
+ Hits         4222     4244      +22     
  Misses        747      747              
  Partials       24       24              
Files Changed Coverage Δ
src/advanced-settings/AdvancedSettings.jsx 89.53% <100.00%> (+0.24%) ⬆️
src/course-team/CourseTeam.jsx 100.00% <100.00%> (ø)
src/course-updates/CourseUpdates.jsx 93.10% <100.00%> (+0.51%) ⬆️
src/custom-pages/CustomPages.jsx 82.50% <100.00%> (+0.92%) ⬆️
src/files-and-uploads/FilesAndUploads.jsx 98.55% <100.00%> (+0.04%) ⬆️
src/generic/utils.js 100.00% <100.00%> (ø)
src/grading-settings/GradingSettings.jsx 79.59% <100.00%> (+0.86%) ⬆️
src/pages-and-resources/PagesAndResources.jsx 65.71% <100.00%> (+2.07%) ⬆️
.../proctored-exam-settings/ProctoredExamSettings.jsx 94.79% <100.00%> (+0.05%) ⬆️
src/schedule-and-details/index.jsx 91.66% <100.00%> (+0.36%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KristinAoki KristinAoki merged commit 2bd8037 into master Sep 6, 2023
5 checks passed
@KristinAoki KristinAoki deleted the KristinAoki/fix-window-tab-title branch September 6, 2023 15:02
snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants