Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement import page #587

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

kyrylo-kh
Copy link
Contributor

Added new page - Import page

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 5, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Thposbsmt! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 92.81% and project coverage change: +0.16% 🎉

Comparison is base (c47c800) 86.45% compared to head (a10f112) 86.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #587      +/-   ##
==========================================
+ Coverage   86.45%   86.61%   +0.16%     
==========================================
  Files         372      386      +14     
  Lines        5580     5731     +151     
  Branches     1235     1256      +21     
==========================================
+ Hits         4824     4964     +140     
- Misses        732      743      +11     
  Partials       24       24              
Files Changed Coverage Δ
src/CourseAuthoringRoutes.jsx 100.00% <ø> (ø)
src/store.js 100.00% <ø> (ø)
src/import-page/data/thunks.js 82.35% <82.35%> (ø)
src/import-page/data/slice.js 90.90% <90.90%> (ø)
src/import-page/file-section/FileSection.jsx 93.33% <93.33%> (ø)
src/import-page/CourseImportPage.jsx 95.23% <95.23%> (ø)
src/import-page/import-stepper/ImportStepper.jsx 96.77% <96.77%> (ø)
src/import-page/data/api.js 100.00% <100.00%> (ø)
src/import-page/data/constants.js 100.00% <100.00%> (ø)
src/import-page/data/selectors.js 100.00% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@e0d
Copy link

e0d commented Sep 5, 2023

Hi @Thposbsmt It looks like this PR reduces coverage and has conflicts with the base. Can you please have a look?

@e0d e0d added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Sep 5, 2023
@KristinAoki
Copy link
Member

Please increase code coverage for files in the data folder

@KristinAoki KristinAoki merged commit 2ea876a into openedx:master Sep 25, 2023
5 checks passed
@openedx-webhooks
Copy link

@Thposbsmt 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

snglth pushed a commit to Abstract-Tech/community-theme-course-authoring that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants