-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement import page #587
feat: implement import page #587
Conversation
Thanks for the pull request, @Thposbsmt! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 86.45% 86.61% +0.16%
==========================================
Files 372 386 +14
Lines 5580 5731 +151
Branches 1235 1256 +21
==========================================
+ Hits 4824 4964 +140
- Misses 732 743 +11
Partials 24 24
☔ View full report in Codecov by Sentry. |
Hi @Thposbsmt It looks like this PR reduces coverage and has conflicts with the base. Can you please have a look? |
aaa6fc6
to
6d1122b
Compare
Please increase code coverage for files in the data folder |
83341eb
to
30c6406
Compare
@Thposbsmt 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Added new page - Import page