Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Paragon stepper fix inside discussions settings #863

Conversation

Lunyachek
Copy link
Contributor

Fixed UI problem in discussions settings stepper. This bug made in this PR #586

Before fix
Снимок экрана 2024-03-05 в 13 07 31
Снимок экрана 2024-03-05 в 13 07 57

After fix
Снимок экрана 2024-03-05 в 13 09 53
Снимок экрана 2024-03-05 в 13 09 58

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 5, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@d0c4765). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #863   +/-   ##
=============================================================
  Coverage                              ?   86.81%           
=============================================================
  Files                                 ?      378           
  Lines                                 ?     5695           
  Branches                              ?     1257           
=============================================================
  Hits                                  ?     4944           
  Misses                                ?      729           
  Partials                              ?       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections except for the fact we should be fixing master first. Is there a corresponding PR, yet?

@Lunyachek
Copy link
Contributor Author

No objections except for the fact we should be fixing master first. Is there a corresponding PR, yet?

In master this bug was fixed - #656

@arbrandes arbrandes merged commit 2b8edfd into openedx:open-release/quince.master Mar 5, 2024
6 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants