Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Persian language Support #279

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Feature: Persian language Support #279

merged 4 commits into from
Jan 23, 2023

Conversation

CodeWithEmad
Copy link
Member

TL;DR - [ A short summary of what this PR does and why ]

Hello everyone
I'm glad to announce that we translated all openedx components in transifex to Persian and fa_IR is 100% translated and 100% reviewed.

What changed?

in this PR, I've added:
new translations to i18n/messages/fa_IR.json,
fa-ir in messages in src/i18n/index.js,
and fa_IR code in transifex_langs variable in Makefile.

is there anything else I should do?

Developer Checklist

  • Test suites passing
  • Documentation and test plan updated, if applicable
  • Received code-owner approving review
  • Bumped version number package.json

Testing Instructions

[ How should a reviewer test this PR? ]

Reviewer Checklist

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

@CodeWithEmad CodeWithEmad requested a review from a team as a code owner October 17, 2022 07:50
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 17, 2022
@mphilbrick211
Copy link

Hi @CodeWithEmad - apologies for the delay on this. I will check in on getting this reviewed. In the meantime, would you mind resolving the branch conflicts?

CC: @openedx/content-aurora @mattcarter

leangseu-edx
leangseu-edx approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@leangseu-edx leangseu-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mphilbrick211
Copy link

Hi @CodeWithEmad! Would you mind resolving the branch conflicts?

CC: @mattcarter @openedx/content-aurora for merging (as owners of the repo). Thanks!

@CodeWithEmad
Copy link
Member Author

Hi @mphilbrick211.
sorry for the delay. all conflicts resolved.

@CodeWithEmad
Copy link
Member Author

also @mphilbrick211
I've added persian langauge support to frontend

@CodeWithEmad
Copy link
Member Author

@mphilbrick211 in the openedx/frontend-platform#385, I've added Persian language support to the frontend-platform repo also.
but looks like they forgot to review/merge it.
that PR was created in October 2022! :)

@e0d
Copy link

e0d commented Jan 20, 2023

@CodeWithEmad I've run the tests and there's a commit lint issue:

⧗   input: reformat: reorder imports alphabetically
✖   type must be one of [revert, feat, fix, perf, docs, test, build, refactor, style, chore, temp] [type-enum]

Can this PR merge prior to openedx/frontend-platform#385? I realize it won't work, but was curious if it would break anything.

@e0d e0d added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 20, 2023
@codecov
Copy link

codecov bot commented Jan 20, 2023 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (6a21c11) compared to base (d0ab0ec).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #279   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1260      1260           
  Branches       248       248           
=========================================
  Hits          1260      1260
Impacted Files Coverage Δ
src/i18n/index.jsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CodeWithEmad
Copy link
Member Author

CodeWithEmad commented Jan 20, 2023 •
edited
Loading

@CodeWithEmad I've run the tests and there's a commit lint issue:

oops. my bad. commit type changed to refactor.

Can this PR merge prior to openedx/frontend-platform#385? I realize it won't work, but was curious if it would break anything.

No, it won't break anything. the only issue here is that the frontend platform doesn't recognize fa-ir code as an RTL language, and it will show the translations from Left to Right. which will be fixed, when they merge that MR.

@e0d
Copy link

e0d commented Jan 20, 2023

@CodeWithEmad excellent, all green now.

@e0d e0d removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 20, 2023
@jansenk jansenk merged commit 0c4675c into openedx:master Jan 23, 2023
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@CodeWithEmad CodeWithEmad deleted the feature/persian-language branch January 24, 2023 06:13
moonesque pushed a commit to edSPIRIT/frontend-app-gradebook that referenced this pull request Nov 11, 2023
@CodeWithEmad @moonesque
Feature: Persian language Support (openedx#279)
84f0be4 
* feat: fa_IR code added to transifex_langs

* feat: Persian language fa-ir added to messages

* feat: Persian translations added

* refactor: reorder imports alphabetically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansenk jansenk jansenk approved these changes

@leangseu-edx leangseu-edx leangseu-edx approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CodeWithEmad @openedx-webhooks @mphilbrick211 @e0d @jansenk @leangseu-edx