Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add JS-based configuration capabilities to Learner Record #275
feat!: Add JS-based configuration capabilities to Learner Record #275
Changes from 3 commits
b943fee
5d1648f
9788e72
797fd31
f453256
68a9e75
40c748e
8115b51
f1347b9
a4689a5
2ad54d9
760051e
e7b851a
8f062be
cec5f45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[clarification] Similar to the other comment, I have a suspicion the
jest/fallback.env.config.js
used in the basejest.config.js
provided by@(open)edx/frontend-build
might be sufficient without having to duplicate into consuming projects?I read this as though
@(open)edx/frontend-build
handles the fallback behind-the-scenes for consuming repositories such that the changes could be released without a breaking change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in your comment in the
jest.config.js
file, I'll very likely remove this for the PR because I agree thatfrontend-build
should already provide this fallback.