fix: add patch for webpack prod config to handle env vars #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* webpack.dev.config.js will be able to use the port number provided in the env.config.js * webpack.prod.config.js will be able to build Learner Record with a JS config passed in during build time * Jest is now set up to retrieve environment variables from a JS config * some tests needed to be fixed
…rogramCertificatesList
* add JS/JSX compatability to jest and webpack configs
….jsx to .gitignore
…ork in development * since frontend-build is a devdependency, post-package will not include its patches in prod
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
=======================================
Coverage 70.22% 70.22%
=======================================
Files 27 27
Lines 403 403
Branches 85 85
=======================================
Hits 283 283
Misses 119 119
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Closed by #282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APER-2786
This is a follow-up to #275 to have Webpack Prod config use
env.config.jsfor assigningNEW_RELIC_APP_IDandBASE_URLduring the creation of two New Relic plugins.This work is a temporary patch until we can add these changes to
frontend-buildand Learner Record migrates from using@edx/frontend-buildto@openedx/frontend-buildas a dependency.