Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a helper function in frontend-build to retrieve relative path from webpack to env.config.js #283

Closed
wants to merge 1 commit into from

Conversation

jsnwesson
Copy link
Contributor

APER-2786

This is a follow-up to #275 to provide the relative path of env.config.js being provided by the environment variable JS_CONFIG_FILEPATH from within webpack.prod.config.js. This will enable webpack to create a copy of env.config.js in Learner Record.

This work is a temporary patch until we can add these changes to frontend-build and Learner Record migrates from using @edx/frontend-build to @openedx/frontend-build as a dependency.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2aac86b) 70.22% compared to head (2df4b7b) 70.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          27       27           
  Lines         403      403           
  Branches       85       85           
=======================================
  Hits          283      283           
  Misses        119      119           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnwesson
Copy link
Contributor Author

Closing this PR due to the fact that it overcomplicates the alternative solution of providing a relative path for env.config.js.

@jsnwesson jsnwesson closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant