-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase subsection grades rounding precision #1397
base: master
Are you sure you want to change the base?
fix: increase subsection grades rounding precision #1397
Conversation
We used two decimal digits to match the experience from the edx-platform. However, openedx/edx-platform#27788 increased the precision to reduce the impact of double rounding.
Thanks for the pull request, @Agrendalath! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1397 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 305 305
Lines 5234 5234
Branches 1327 1330 +3
=======================================
Hits 4646 4646
Misses 572 572
Partials 16 16 ☔ View full report in Codecov by Sentry. |
@Agrendalath Thank you for this contribution! It looks like the older PR that you mentioned in the description (openedx/edx-platform#27788) is tagged for product review. Should we do the same here? |
@Agrendalath OK great, I'll add the |
@Agrendalath It looks like you got the go-ahead from product! I updated labels and Contribution board status of this PR and openedx/edx-platform#27788 to reflect that. Please ping |
We used two decimal digits to match the experience from the edx-platform. However, openedx/edx-platform#27788 increased the precision to reduce the impact of double rounding.
See the details and testing instructions at openedx/edx-platform#27788.
Private-ref: BB-4210