fix: corrects the navigation issue if the student does not pass the entrance exam #1429

imasdekar · 2024-08-02T07:13:00Z

adds checks while rendering the next button text for status of the entrance exam.

closes #1415

Signed-off by: Ishan Masdekar [email protected]

openedx-webhooks · 2024-08-02T07:13:04Z

Thanks for the pull request, @imasdekar!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

imasdekar · 2024-08-07T14:04:25Z

@mphilbrick211 Can you please get the checks run and get this reviewed?

GlugovGrGlib · 2024-08-07T18:13:06Z

@imasdekar I believe we need to wait another week until @bradenmacdonald and @farhaanbukhsh take on maintainer responsibilities for this repo, after this it can be reviewed and scheduled for merge

codecov · 2024-08-08T01:37:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.80%. Comparing base (b9d1198) to head (c98da6d).
Report is 3 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
+ Coverage   87.78%   87.80%   +0.01%     
==========================================
  Files         310      310              
  Lines        5320     5328       +8     
  Branches     1350     1355       +5     
==========================================
+ Hits         4670     4678       +8     
  Misses        633      633              
  Partials       17       17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

itsjeyd · 2024-08-08T07:53:47Z

Hi @imasdekar, thank you for this contribution!

itsjeyd · 2024-08-08T07:56:59Z

OSPR management note: This PR includes user-facing changes. However, it fixes an existing bug (#1415) so there should be no need to send it through product review.

CC @jmakowski1123

src/course-home/progress-tab/certificate-status/CertificateStatus.jsx

bradenmacdonald · 2024-09-11T18:52:47Z

src/courseware/course/course-exit/utils.js

  );
-  const exitActive = exitMode !== COURSE_EXIT_MODES.disabled;
+  const exitActive = ((exitMode !== COURSE_EXIT_MODES.disabled) && (exitMode !== COURSE_EXIT_MODES.entranceExamFail));


Can you help me understand this? What exactly does exitActive mean and what are the various exit modes? Just want to make sure this logic is correct, but I'm not clear on what's even going on here.

I'd love if you could add a few JSDoc comments to this file as part of this PR to explain what an "exit mode" is and what each of the COURSE_EXIT_MODES mean. And why exitActive should be false when the exit mode is entranceExamFail ??

exitActive is used to enable/disable the exit mode i.e. the next buttons.
Available COURSE_EXIT_MODES: disabled, celebration, nonPassing, inProgress, entranceExamFail
So if the user has failed the entrance exam, access to further course sections should be disabled

I've added some comments in the code as per your suggestion. Let me know if more explanation is needed in the comments and I will add accordingly.

bradenmacdonald

Thanks for the fix. I tested it and confirmed the issue is fixed. Although there is still obviously a major bug on the backend - it should be refusing to provide the rest of the course to the user who hasn't passed the exam, regardless of what logic we have on the frontend.

bradenmacdonald

@imasdekar Actually could you please add a test case for this too? That will fix the coverage problem. Sorry, I just noticed now there isn't a new test.

imasdekar · 2024-09-16T06:26:06Z

@bradenmacdonald before implementing this fix on the frontend I dis check the backend and found that the entrance data is sent to the frontend and the respective data has a field which states that the user has failed the entrance exam. Hence I decided to utilise the same and implement a fix on the frontend.

imasdekar · 2024-09-16T06:28:08Z

I will add a test case and update this PR.

imasdekar · 2024-09-16T06:30:25Z

@bradenmacdonald If req. is also that further course data not be sent from the backend at all if the entrance exam status is failed then what exactly should be the response in such a case? I can work on this backend fix as well.

bradenmacdonald · 2024-09-16T16:45:35Z

Great! Replied on #1415.

…ntrance exam - adds checks while rendering the next button text for status of the entrance exam. closes openedx#1415 Signed-off by: Ishan Masdekar <[email protected]>

imasdekar · 2024-09-23T09:32:22Z

@bradenmacdonald I've added tests as required.

bradenmacdonald · 2024-09-23T16:41:45Z

Thanks @imasdekar ! Unfortunately the test is not passing on CI - can you please take a quick look?

- Introduces a test case each for scenarios where the entrance exam status is failed and pass Signed-off by: Ishan Masdekar <[email protected]>

imasdekar · 2024-09-23T16:59:18Z

@bradenmacdonald apologies, it should work now. I missed to push a small update.

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 2, 2024

imasdekar mentioned this pull request Aug 2, 2024

[Bug] Students have access to course content even if the Entrance Exam wasn't finished #1415

Closed

imasdekar force-pushed the entrance_exam_navigation branch from b739317 to 5dc0480 Compare August 7, 2024 07:40

imasdekar marked this pull request as ready for review August 7, 2024 07:42

itsjeyd added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 8, 2024

itsjeyd requested a review from a team September 7, 2024 08:06

bradenmacdonald reviewed Sep 11, 2024

View reviewed changes

imasdekar force-pushed the entrance_exam_navigation branch from 5dc0480 to ba2fbc8 Compare September 13, 2024 06:27

bradenmacdonald approved these changes Sep 13, 2024

View reviewed changes

bradenmacdonald requested changes Sep 13, 2024

View reviewed changes

itsjeyd added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Sep 20, 2024

fix: corrects the navigation issue if the student does not pass the e…

1d401bb

…ntrance exam - adds checks while rendering the next button text for status of the entrance exam. closes openedx#1415 Signed-off by: Ishan Masdekar <[email protected]>

imasdekar force-pushed the entrance_exam_navigation branch from ba2fbc8 to e2d1e28 Compare September 23, 2024 09:30

test: test for entrance exam failed

c98da6d

- Introduces a test case each for scenarios where the entrance exam status is failed and pass Signed-off by: Ishan Masdekar <[email protected]>

imasdekar force-pushed the entrance_exam_navigation branch from e2d1e28 to c98da6d Compare September 23, 2024 16:58

bradenmacdonald approved these changes Sep 23, 2024

View reviewed changes

bradenmacdonald merged commit fbe1648 into openedx:master Sep 23, 2024
8 checks passed

itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: corrects the navigation issue if the student does not pass the entrance exam #1429

fix: corrects the navigation issue if the student does not pass the entrance exam #1429

imasdekar commented Aug 2, 2024

openedx-webhooks commented Aug 2, 2024 •

edited

Loading

imasdekar commented Aug 7, 2024

GlugovGrGlib commented Aug 7, 2024

codecov bot commented Aug 8, 2024 •

edited

Loading

itsjeyd commented Aug 8, 2024

itsjeyd commented Aug 8, 2024

bradenmacdonald Sep 11, 2024 •

edited

Loading

imasdekar Sep 13, 2024

imasdekar Sep 13, 2024

bradenmacdonald left a comment

bradenmacdonald left a comment

imasdekar commented Sep 16, 2024

imasdekar commented Sep 16, 2024

imasdekar commented Sep 16, 2024

bradenmacdonald commented Sep 16, 2024

imasdekar commented Sep 23, 2024

bradenmacdonald commented Sep 23, 2024

imasdekar commented Sep 23, 2024 •

edited

Loading

fix: corrects the navigation issue if the student does not pass the entrance exam #1429

fix: corrects the navigation issue if the student does not pass the entrance exam #1429

Conversation

imasdekar commented Aug 2, 2024

openedx-webhooks commented Aug 2, 2024 • edited Loading

What's next?

🔘 Get product approval

🔘 Provide context

🔘 Get a green build

🔘 Let us know that your PR is ready for review:

Who will review my changes?

Where can I find more information?

When can I expect my changes to be merged?

imasdekar commented Aug 7, 2024

GlugovGrGlib commented Aug 7, 2024

codecov bot commented Aug 8, 2024 • edited Loading

Codecov Report

itsjeyd commented Aug 8, 2024

itsjeyd commented Aug 8, 2024

bradenmacdonald Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

imasdekar Sep 13, 2024

Choose a reason for hiding this comment

imasdekar Sep 13, 2024

Choose a reason for hiding this comment

bradenmacdonald left a comment

Choose a reason for hiding this comment

bradenmacdonald left a comment

Choose a reason for hiding this comment

imasdekar commented Sep 16, 2024

imasdekar commented Sep 16, 2024

imasdekar commented Sep 16, 2024

bradenmacdonald commented Sep 16, 2024

imasdekar commented Sep 23, 2024

bradenmacdonald commented Sep 23, 2024

imasdekar commented Sep 23, 2024 • edited Loading

openedx-webhooks commented Aug 2, 2024 •

edited

Loading

codecov bot commented Aug 8, 2024 •

edited

Loading

bradenmacdonald Sep 11, 2024 •

edited

Loading

imasdekar commented Sep 23, 2024 •

edited

Loading