Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgraded frontend-build version to v12 #757

Merged
merged 26 commits into from
Jan 23, 2023
Merged

refactor: upgraded frontend-build version to v12 #757

merged 26 commits into from
Jan 23, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jul 18, 2022 •
edited
Loading

GIT Ticket: 42: Upgrade eslint to v8.x

What changed?

  • Updated frontend-build to v12 (Eslint was updated in frontend-build version resulting in it's version being bumped to v12. This PR updates frontend-build to reciprocate eslint version update)
  • Resolved eslint issues

@BilalQamar95 BilalQamar95 reopened this Jul 25, 2022
@mphilbrick211
Copy link

Hi @BilalQamar95! Just checking to see if you intend to proceed with this PR? If so, please note, the branch conflicts must be resolved before review/merge. Thank you!

@BilalQamar95
Copy link
Contributor Author

Hi @BilalQamar95! Just checking to see if you intend to proceed with this PR? If so, please note, the branch conflicts must be resolved before review/merge. Thank you!

Hi @mphilbrick211, I have updated the PR to latest frontend-build version & resolved subsequent eslint issues along with merge conflicts. PR is ready to be reviewed.

@arbrandes arbrandes mentioned this pull request Nov 1, 2022
Closed
27 tasks
@mphilbrick211
Copy link

Hi @BilalQamar95! Would you mind rebasing to resolve the branch conflicts?

CC: @ansabgillani - this should be ready to merge once the branch item is resovled.

@BilalQamar95
Copy link
Contributor Author

Hi @mphilbrick211, I have resolved the merge conflicts

@mphilbrick211 mphilbrick211 removed the request for review from azanbinzahid January 10, 2023 17:40
@mphilbrick211
Copy link

Hi @BilalQamar95 - looks like more conflicts need to be resolved.

@ansabgillani - flagging for you since this looks like it might be good-to-go once the conflicts are resolved.

@BilalQamar95
Copy link
Contributor Author

Hi @mphilbrick211, I have resolved the merge conflicts

@mphilbrick211
Copy link

I'm not sure why, but the branch error still says out-of-date @BilalQamar95.

@BilalQamar95
Copy link
Contributor Author

@mphilbrick211 I just updated it from master branch

@arbrandes arbrandes changed the title Upgraded frontend-build version to v12 refactor: upgraded frontend-build version to v12 Jan 23, 2023
@arbrandes arbrandes merged commit 24ec752 into openedx:master Jan 23, 2023
@arbrandes arbrandes mentioned this pull request Jan 23, 2023
Closed
44 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ansabgillani ansabgillani ansabgillani approved these changes

Assignees
No one assigned
Labels
engineering review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BilalQamar95 @mphilbrick211 @ansabgillani @arbrandes