chore: remove unhandledPromiseRejection Error in Frontend-app-publisher #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AfaqShuaib09
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #976 +/- ##
=======================================
Coverage 67.77% 67.77%
=======================================
Files 128 128
Lines 3230 3230
Branches 936 936
=======================================
Hits 2189 2189
+ Misses 996 993 -3
- Partials 45 48 +3 ☔ View full report in Codecov by Sentry. |
Ali-D-Akbar
approved these changes
Aug 16, 2024
DawoudSheraz
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PROD-3142
This PR removes the workaround for ignoring unhandledPromiseRejection warnings. Previously, unhandledPromiseRejection warnings were converted to errors in Node.js 15, when we run tests on Node.js 16 so this workaround added at that time.