-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make it possible to disable NewRelic globally #215
Conversation
Thanks for the pull request, @regisb! I've created OSPR-6240 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
36383a8
to
e8f2221
Compare
By defining the `ENABLE_NEW_RELIC='false'` environment variable, the new relic logging integration will be disabled, which is a must-have for most non-edX platforms. Close openedx/wg-frontend#14
e8f2221
to
c209540
Compare
@regisb Thank you for your contribution. We will review this as soon as we can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for the reviews! Can we merge this and make a release? We will then have to upgrade frontend-build in the account, ecommerce gradebook, learning, payment, profile MFEs. |
@regisb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
🎉 This PR is included in version 8.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
By defining the
ENABLE_NEW_RELIC='false'
environment variable, the new reliclogging integration will be disabled, which is a must-have for most non-edX
platforms.
Close openedx/wg-frontend#14
cc @davidjoy.