Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make it possible to disable NewRelic globally #215

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

regisb
Copy link
Contributor

@regisb regisb commented Nov 25, 2021

By defining the ENABLE_NEW_RELIC='false' environment variable, the new relic
logging integration will be disabled, which is a must-have for most non-edX
platforms.

Close openedx/wg-frontend#14

cc @davidjoy.

@openedx-webhooks
Copy link

Thanks for the pull request, @regisb! I've created OSPR-6240 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

By defining the `ENABLE_NEW_RELIC='false'` environment variable, the new relic
logging integration will be disabled, which is a must-have for most non-edX
platforms.

Close openedx/wg-frontend#14
@natabene
Copy link

natabene commented Dec 7, 2021

@regisb Thank you for your contribution. We will review this as soon as we can.

Copy link

@manny-m manny-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@regisb
Copy link
Contributor Author

regisb commented Dec 8, 2021

Thanks for the reviews! Can we merge this and make a release? We will then have to upgrade frontend-build in the account, ecommerce gradebook, learning, payment, profile MFEs.

@macdiesel macdiesel merged commit ed3f2db into openedx:master Dec 8, 2021
@openedx-webhooks
Copy link

@regisb 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-semantic-release
Copy link

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuration of frontend-platform services without forking
7 participants