Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend-build to v12 #249

Merged
merged 10 commits into from
Oct 26, 2022
Merged

Conversation

BilalQamar95
Copy link
Contributor

Ticket:
42: Upgrade eslint to v8.x

What changed?

  • Updated frontend-build to v12 (Eslint was updated in frontend-build version resulting in it's version being bumped to v12. This PR updates frontend-build to reciprocate eslint version update)
  • Resolved eslint issues post update

@BilalQamar95 BilalQamar95 requested a review from a team August 11, 2022 09:52
@BilalQamar95 BilalQamar95 self-assigned this Aug 11, 2022
@codecov
Copy link

codecov bot commented Aug 11, 2022

Codecov Report

Base: 60.86% // Head: 61.87% // Increases project coverage by +1.00% 🎉

Coverage data is based on head (a31861a) compared to base (acaf98f).
Patch coverage: 95.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   60.86%   61.87%   +1.00%     
==========================================
  Files          15       15              
  Lines         299      299              
  Branches       70       70              
==========================================
+ Hits          182      185       +3     
+ Misses        115      112       -3     
  Partials        2        2              
Impacted Files Coverage Δ
src/learning-header/AnonymousUserMenu.jsx 66.66% <50.00%> (+33.33%) ⬆️
src/Avatar.jsx 87.50% <100.00%> (+1.78%) ⬆️
src/Header.jsx 89.47% <100.00%> (ø)
src/Icons.jsx 100.00% <100.00%> (ø)
src/Logo.jsx 100.00% <100.00%> (ø)
src/Menu/Menu.jsx 30.70% <100.00%> (+0.47%) ⬆️
src/StudioHeader.jsx 81.81% <100.00%> (ø)
src/learning-header/AuthenticatedUserDropdown.jsx 83.33% <100.00%> (ø)
src/learning-header/LearningHeader.jsx 92.85% <100.00%> (+0.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arbrandes
Copy link
Contributor

@BilalQamar95, are we still doing this one? It looks good, but it might be worth rebasing and regenerating package-lock.

@BilalQamar95
Copy link
Contributor Author

BilalQamar95 commented Oct 26, 2022

@BilalQamar95, are we still doing this one? It looks good, but it might be worth rebasing and regenerating package-lock.

@arbrandes Yes, we are. I have regenerated package-lock.

@arbrandes arbrandes merged commit 6c02962 into master Oct 26, 2022
@arbrandes arbrandes deleted the bilalqamar95/frontend-build-upgrade branch October 26, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants