-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/ add Vietnamese support language #344
Conversation
Thanks for the pull request, @DAN3002! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@DAN3002 Thank you for the PR. Once your CLA forms have been processed, we will be able to review your code. |
@DAN3002 This is now ready for our review, I will line this up with our internal teams. |
Flagging this PR as it's been inactive for a while. Looks like it has not been looked at by 2U. Just seeing if it's still necessary? CC: @Carlos-Muniz @openedx/fed-bom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example app and build working fine. Also tested in consuming MFEs, working fine. Only thing that is required is, test case need to be updated as it is failing for new language "Vietnamese" in frontend-platform.
@ishahroz Hi, |
@DAN3002 When you try to run test cases for |
Hi @DAN3002! Friendly follow-up on the requested changes. |
Hi @DAN3002! Just checking back on this to see if changes were made and/or this is ready to review? Thanks! |
Hi @DAN3002 - just checking in on this :) |
@arbrandes @ishahroz - we have not heard back from this author - are we still going to pursue this PR? |
@mphilbrick211, I think it's important for community members that propose i18n improvements such as this one to be able to follow up on their contributions. Otherwise, it would be difficult for us to test that they're working satisfactorily. Until somebody else steps up to "maintain" vietnamese support, we should probably put this on the backburner. |
Closing this for now as it's been inactive. |
@DAN3002 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Description:
In our edx-plasform app, we need VIetnamese support language (in MFE). So this PR will add vi locate into i18n
Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: