Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ add Vietnamese support language #344

Closed
wants to merge 1 commit into from
Closed

feat/ add Vietnamese support language #344

wants to merge 1 commit into from

Conversation

DAN3002
Copy link

@DAN3002 DAN3002 commented Jun 11, 2022

Description:

In our edx-plasform app, we need VIetnamese support language (in MFE). So this PR will add vi locate into i18n

Merge checklist:

  • Consider running your code modifications in the included example app within frontend-platform. This can be done by running npm start and opening http://localhost:8080.
  • Consider testing your code modifications in another local micro-frontend using local aliases configured via the module.config.js file in frontend-build.
  • Verify your commit title/body conforms to the conventional commits format (e.g., fix, feat) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.

Post merge:

  • After the build finishes for the merged commit, verify the new release has been pushed to NPM.

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 11, 2022

Thanks for the pull request, @DAN3002! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@natabene
Copy link

@DAN3002 Thank you for the PR. Once your CLA forms have been processed, we will be able to review your code.

@natabene natabene changed the title feat/ add Vietnamese support language feat/ add Vietnamese support language Jul 20, 2022
@natabene natabene changed the title feat/ add Vietnamese support language feat/ add Vietnamese support language Jul 20, 2022
@natabene
Copy link

@DAN3002 This is now ready for our review, I will line this up with our internal teams.

@mphilbrick211 mphilbrick211 requested a review from a team December 27, 2022 23:03
@mphilbrick211
Copy link

Flagging this PR as it's been inactive for a while. Looks like it has not been looked at by 2U. Just seeing if it's still necessary?

CC: @Carlos-Muniz @openedx/fed-bom

@mphilbrick211 mphilbrick211 added the inactive PR author has been unresponsive for several months label Dec 27, 2022
Copy link
Member

@ishahroz ishahroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example app and build working fine. Also tested in consuming MFEs, working fine. Only thing that is required is, test case need to be updated as it is failing for new language "Vietnamese" in frontend-platform.

@DAN3002
Copy link
Author

DAN3002 commented Jan 3, 2023

@ishahroz Hi,
So i need to update test case for Vietnamese in repo call "frontend-platform" and not this repo right?

@ishahroz
Copy link
Member

ishahroz commented Jan 3, 2023

@ishahroz Hi, So i need to update test case for Vietnamese in repo call "frontend-platform" and not this repo right?

@DAN3002 When you try to run test cases for frontend-platform locally, you will see failure and some warnings related to Vietnamese language support. So, need to update failing and warning test suites in order to incorporate Vietnamese language. And yes, these test cases will be updated in this repo (which is frontend-platform).

@mphilbrick211 mphilbrick211 added changes requested and removed inactive PR author has been unresponsive for several months labels Jan 4, 2023
@mphilbrick211
Copy link

Hi @DAN3002! Friendly follow-up on the requested changes.

@mphilbrick211
Copy link

Hi @DAN3002! Just checking back on this to see if changes were made and/or this is ready to review? Thanks!

@mphilbrick211
Copy link

Hi @DAN3002 - just checking in on this :)

@mphilbrick211
Copy link

@arbrandes @ishahroz - we have not heard back from this author - are we still going to pursue this PR?

@arbrandes
Copy link
Contributor

@mphilbrick211, I think it's important for community members that propose i18n improvements such as this one to be able to follow up on their contributions. Otherwise, it would be difficult for us to test that they're working satisfactorily. Until somebody else steps up to "maintain" vietnamese support, we should probably put this on the backburner.

@mphilbrick211 mphilbrick211 added the closed inactivity PR was closed because the author abandoned it label Jun 20, 2023
@mphilbrick211
Copy link

Closing this for now as it's been inactive.

@openedx-webhooks
Copy link

@DAN3002 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed inactivity PR was closed because the author abandoned it open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants