Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use shared browserslist config #374

Closed

Conversation

adamstankiewicz
Copy link
Member

  • Removes custom browserslist configuration in favor of using a shared configuration.
  • Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.

This change reduces the resultant asset bundle size.

@adamstankiewicz adamstankiewicz requested a review from a team November 3, 2021 04:06
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2021

Codecov Report

Merging #374 (f77cbbb) into master (1a04527) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #374   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines           7       7           
======================================
  Misses          7       7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a04527...f77cbbb. Read the comment docs.

@Jawayria Jawayria force-pushed the astankiewicz/shared-browserslist-config branch from f77cbbb to c688201 Compare June 3, 2022 11:11
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #374 (c688201) into master (286d37d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #374   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines           7       7           
======================================
  Misses          7       7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 286d37d...c688201. Read the comment docs.

@davidjoy
Copy link
Contributor

davidjoy commented Jun 3, 2022

Is this good to go? If so, feel free to merge it.

@e0d
Copy link

e0d commented Jan 6, 2023

@adamstankiewicz still make sense to merge?

@arbrandes
Copy link
Contributor

This is stale: we already have browserslist config in there.

@arbrandes arbrandes closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants