Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Mark OEP-48 as Approved and OEP-23 as replaced #395

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

xitij2000
Copy link
Contributor

OEP-48 deals with customising branding for MFEs usin an npm package override.
This mechanism for branding is now supported across all MFEs, and is also
supported by both the configuration repo, and Tutor. As such this PR updates its
status from Provisional to Accepted.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 7, 2022
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 7, 2022

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@xitij2000 xitij2000 marked this pull request as ready for review October 7, 2022 07:27
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @xitij2000 , I agree it's time to mark this as complete. Could you:

  • mark OEP-23 as "Replaced"
  • add a changelog entry to the bottom of this OEP as well as OEP-23
  • post this PR in the #open-edx-proposals channel and wait a week, just to give folks a chance to raise their hand if they disagree

OEP-48 deals with customising branding for MFEs usin an npm package override.
This mechanism for branding is now supported across all MFEs, and is also
supported by both the configuration repo, and Tutor. As such this PR updates its
status from Provisional to Accepted.
@xitij2000
Copy link
Contributor Author

Thanks for making this change @xitij2000 , I agree it's time to mark this as complete. Could you:

* mark OEP-23 as "Replaced"

* add a changelog entry to the bottom of this OEP as well as OEP-23

* post this PR in the #open-edx-proposals channel and wait a week, just to give folks a chance to raise their hand if they disagree

Sorry for the delay. I've updated the PR.

@xitij2000 xitij2000 changed the title docs: Mark OEP-48 as Approved docs: Mark OEP-48 as Approved and OEP-23 as replaced Oct 27, 2022
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@itsjeyd
Copy link

itsjeyd commented Nov 14, 2022

Hey @kdmccormick and @arbrandes! Now that this PR is ready to go, would it be possible to move forward with merging it? I'm not sure who has permission to hit the button; please let me know if there's someone else I should ping.

CC @mphilbrick211

@kdmccormick kdmccormick merged commit 6c1927b into master Nov 14, 2022
@kdmccormick kdmccormick deleted the kshitij/accept-adr-48 branch November 14, 2022 14:47
@openedx-webhooks
Copy link

@xitij2000 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants