Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEPR]: BLOCK_STRUCTURES_SETTINGS['PRUNING_ACTIVE'] in edx-platform #31

Closed
feanil opened this issue Feb 24, 2022 · 2 comments
Closed

[DEPR]: BLOCK_STRUCTURES_SETTINGS['PRUNING_ACTIVE'] in edx-platform #31

feanil opened this issue Feb 24, 2022 · 2 comments
Labels
depr Proposal for deprecation & removal per OEP-21 good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community

Comments

@feanil
Copy link

feanil commented Feb 24, 2022

Proposal Date

9 February 2021

Ticket Acceptance Date

1 March 2021

Technology Removal Date

TBD

First Open edX Named Release Without This Functionality

TBD

Rationale

See removal section.

Removal

Removing: Toggle labeled 'BLOCK_STRUCTURES_SETTINGS['PRUNING_ACTIVE']. The toggle has the following annotation as a description:

When True, only a specified number of versions of block structure files are kept for each structure, and the rest are cleaned up. The number of versions that are kept can be specified in the BlockStructureConfiguration, which can be edited in Django Admin. The default number of versions that are kept is 5.

This setting current defaults to False, but we will be setting it as True to avoid having issues when deprecating block_structure.storage_backing_for_cache, which we will make default to True. See https://openedx.atlassian.net/browse/DEPR-145
. Keeping this feature enabled helps prevent run away storage use.

Replacement

No replacement is intended as no use case can be found for disabling it. It will stay enabled, keeping cached versions of block structure in storage.

Deprecation

No response

Migration

No response

Additional Info

Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-146

Original Context Conversation: https://github.com/edx/edx-platform/pull/26175/files#r565801078

@feanil feanil added the depr Proposal for deprecation & removal per OEP-21 label Feb 24, 2022
@ormsbee ormsbee self-assigned this Jun 7, 2022
@feanil
Copy link
Author

feanil commented Aug 16, 2022

@feanil feanil self-assigned this Jan 30, 2023
@dianakhuang dianakhuang added good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community labels Jun 29, 2023
@dianakhuang
Copy link

We have a PR to address this, but we need to figure out what's going on with the test failures: openedx/edx-platform#32496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depr Proposal for deprecation & removal per OEP-21 good first issue A good task for a newcomer to start with help wanted Ready to be picked up by anyone in the community
Projects
Status: Done
Archived in project
Development

No branches or pull requests

3 participants