-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEPR]: block_structure.storage_backing_for_cache in edx-platform #32
Comments
This was announced a while back: https://discuss.openedx.org/t/deprecation-removal-several-block-structure-caching-settings-depr-143-depr-144-depr-145-depr-146/4288 We can mark it as accepted. |
When testing, we should confirm that when a Studio publish happens that we have a backend write to storage. Ensure that the progress page work after Studio publish (and reflect Studio changes). |
@dianakhuang I am working on this ticket. |
@ajamal-python , we would like to remove the toggle entirely, and to have the code behave as if the value is set to true. Does that clarify the ticket? |
@dianakhuang , please clarify following points- |
@ajamal-python If you want to set it locally, you would need to enable it through a waffle flag in django admin. I do believe we need to add STORAGE_CLASS and STORAGE_KWARGS to cms/envs/common.py. |
@dianakhuang when I set |
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This work is part of DEPR openedx/public-engineering#32 Now that we've removed all uses for this switch remove the decleration as well. BREAKING CHANGE: The `block_structure.storage_backing_for_cache` will no longer exist and its value will be ignored. If you have this switch set in your instance you can remove it. The backing cache is now always ON.
This has merge via openedx/edx-platform#35185 but waiting to make sure it doesn't get rolled back before closing this DEPR. |
This has merged and has not seen any issues in the last 24 hrs so closing this as complete. |
Proposal Date
9 February 2021
Ticket Acceptance Date
1 March 2021
Technology Removal Date
TBD
First Open edX Named Release Without This Functionality
TBD
Rationale
See Removal Section
Removal
Removing: Toggle labeled 'block_structure.storage_backing_for_cache'. The toggle has the following annotation as a description:
This toggle defaults to False, however in deprecation we intend to set it to True. We could not think of a reason not to have this toggle on, even in development.bling this switch is recommended for Production.
This toggle defaults to False, however in deprecation we intend to set it to True. We could not think of a reason not to have this toggle on, even in development.
Replacement
No replacement is intended as no use case can be found for it. You can, however, specify where the storage is set. You could, for instance, set it to AWS block storage, or to local disk. The setting BLOCK_STRUCTURES_SETTINGS['STORAGE_CLASS'] covers this need.
Deprecation
No response
Migration
No response
Additional Info
Original Conversation: https://github.com/edx/edx-platform/pull/26175/files#r565801078
Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-145
Relates to #31
The text was updated successfully, but these errors were encountered: