Fixing extra colons in LTI key (#70)

Co-authored-by: Sankar Raj <[email protected]>

lti_consumer/lti_xblock.py

@@ -656,7 +656,13 @@ def lti_provider_key_secret(self):
         """
         for lti_passport in self.course.lti_passports:
             try:
-                lti_id, key, secret = [i.strip() for i in lti_passport.split(':')]
+                # NOTE While unpacking the lti_passport by using ":" as delimiter, first item will be lti_id,
+                #  last item will be client_secret and the rest are considered as client_key.
+                #  So you can have more than one colon for client_key.
+                lti_id, *key, secret = [i.strip() for i in lti_passport.split(':')]
+                if not key:
+                    raise ValueError
+                key = ':'.join(key)
             except ValueError:
                 msg = 'Could not parse LTI passport: {lti_passport!r}. Should be "id:key:secret" string.'
                 msg = self.ugettext(msg).format(lti_passport=lti_passport)

lti_consumer/tests/unit/test_lti_xblock.py

@@ -170,6 +170,21 @@ def test_lti_provider_key_secret(self, mock_course):
         self.assertEqual(lti_provider_key, key)
         self.assertEqual(lti_provider_secret, secret)
 
+    @patch('lti_consumer.lti_xblock.LtiConsumerXBlock.course')
+    def test_lti_provider_key_with_extra_colons(self, mock_course):
+        """
+        Test `lti_provider_key` returns correct key and secret, even if key has more colons.
+        """
+        provider = 'lti_provider'
+        key = '1:10:test'
+        secret = 'secret'
+        self.xblock.lti_id = provider
+        type(mock_course).lti_passports = PropertyMock(return_value=["{}:{}:{}".format(provider, key, secret)])
+        lti_provider_key, lti_provider_secret = self.xblock.lti_provider_key_secret
+
+        self.assertEqual(lti_provider_key, key)
+        self.assertEqual(lti_provider_secret, secret)
+
     @patch('lti_consumer.lti_xblock.LtiConsumerXBlock.course')
     def test_lti_provider_key_secret_not_found(self, mock_course):
         """