Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race conditions when multiple XBlocks are in a single unit #379

Open
Agrendalath opened this issue Jun 2, 2023 · 5 comments
Open

Race conditions when multiple XBlocks are in a single unit #379

Agrendalath opened this issue Jun 2, 2023 · 5 comments
Labels
bug Report of or fix for something that isn't working as intended documentation Relates to documentation improvements good first issue A good task for a newcomer to start with

Comments

@Agrendalath
Copy link
Member

Agrendalath commented Jun 2, 2023

There is a race condition when there are multiple LTI Consumer XBlocks in a single unit. The first block has a correct LTI ID, and the second one has an incorrect one. I didn't change anything between these screenshots - I only refreshed the page.

The first refresh
The second refresh

Originally posted by @Agrendalath in #378 (comment)

Update: we have the solution, but we still need to update the docs.

@Agrendalath Agrendalath added the bug Report of or fix for something that isn't working as intended label Jun 2, 2023
@RafayGhafoor
Copy link

@Agrendalath, The error is from the lti_url i.e., https://saltire.lti.app/tool and doesn't occur when the url used is from the docs i.e., https://lti.tools/saltire/tp

I have checked the network logs and the requests propagate correctly in the right manner from the launch_handler, the resource ids are sent correct, similarly the post request going to the Saltire LTI for registering the event is also correct but the responses received from them always contain the same resource id, so all the verification results are basically the same. This seems like a bug on the saltire lti app tool which is not sending the responses in correct way.

@navinkarkera
Copy link

@RafayGhafoor Just to be certain, the problem will be solved if we use https://lti.tools/saltire/tp as the lti_url?

@RafayGhafoor
Copy link

RafayGhafoor commented Sep 19, 2023

@navinkarkera yes, that's right.

@Agrendalath
Copy link
Member Author

@RafayGhafoor, https://saltire.lti.app/ is a newer page version (with LTI 1.3 support), so we should contact them about this bug. I'll leave the details in the Jira ticket (private link).

@Agrendalath
Copy link
Member Author

Update: Stephen from SPV Software Products resolved this by adding an option to turn off page refreshes. We can use it through the query param: https://saltire.lti.app/tool?norefresh.

The only remaining step here is updating the docs.

@Agrendalath Agrendalath added good first issue A good task for a newcomer to start with documentation Relates to documentation improvements labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of or fix for something that isn't working as intended documentation Relates to documentation improvements good first issue A good task for a newcomer to start with
Projects
Status: Backlog
Development

No branches or pull requests

3 participants