-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-218] fix: Change user from None to Anonymous User in authenticated requests #228
[ISSUE-218] fix: Change user from None to Anonymous User in authenticated requests #228
Conversation
Thanks for the pull request, @OlhaShyliaieva! I've created OSPR-6428 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
@giovannicimolin do you have an idea why you (or edX) did not face this issue before? Unless I'm mistaken it should occur for every LTI 1.3 unit, right? |
No idea, I even tried reproducing it on my devstack without success. I worked for me during the implementation phase as well as for @nedbat when he ran the IMS certification tool. @OlhaShyliaieva Thanks for the contribution! Can you sign the contributor agreement and ping me once it's done? Only then I'll be able to review + move this forward. 😁 |
@OlhaShyliaieva we've processed an individual CLA for you, but I believe this should be covered under the RaccoonGang Entity CLA. @idegtiarov can you confirm? |
@OlhaShyliaieva Thank you for your contribution. |
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 66 66
Lines 4696 4697 +1
=======================================
+ Hits 4562 4563 +1
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @e0d I confirm @OlhaShyliaieva is covered with the RaccoonGang Entity CLA. |
@idegtiarov Thanks for confirming. @e0d Please update the file once you have a chance. |
@natabene CLA check is green now. 😄 @OlhaShyliaieva Can you add in a minor version bump (here) and add a changelog entry? |
@giovannicimolin Done |
I still see a conflict. |
@OlhaShyliaieva I just tested the change and it's working perfectly. A few changes were merged in while this was in my backlog, so can you update the version bump and changelog? Once you do it I'll approve the PR and merge the changes. |
Modified the Lti1p3ApiAuthentication authentication backend to return AnonymousUser instead of None. This allows DarkLangMiddleware to work properly without crashing when middleware tries to get a user info from the request. This investigation and patch was originally done by @OlhaShyliaieva in: openedx#228 I'm just rebasing it onto the latest version to land this change.
Modified the Lti1p3ApiAuthentication authentication backend to return AnonymousUser instead of None. This allows DarkLangMiddleware to work properly without crashing when middleware tries to get a user info from the request. This investigation and patch was originally done by @OlhaShyliaieva in: openedx#228 I'm just rebasing it onto the latest version to land this change.
…#261) Modified the Lti1p3ApiAuthentication authentication backend to return AnonymousUser instead of None. This allows DarkLangMiddleware to work properly without crashing when middleware tries to get a user info from the request. This investigation and patch was originally done by @OlhaShyliaieva in: #228 I'm just rebasing it onto the latest version to land this change.
I merged this change in a different PR: #261 |
@OlhaShyliaieva Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Modified the Lti1p3ApiAuthentication authentication backend to return AnonymousUser instead of None. This allows DarkLangMiddleware to work properly without crashing when middleware tries to get a user info from the request. This investigation and patch was originally done by @OlhaShyliaieva in: #228 This is a Nutmeg backport of the 4.2.2 release. See: #261 I'm just rebasing it onto the latest version to land this change.
Description
Modified the
Lti1p3ApiAuthentication
authentication backend. Set up in requestAnonymousUser
instead ofNone
.It allows
DarkLangMiddleware
to work properly without crashing when middleware tries to get a user from the request.Supporting information
Issue: #218