Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BD-24] [TNL-7318]: BB-2355 - Add decoding and scope verification methods #95

Merged
merged 1 commit into from
Aug 13, 2020
Merged

[BD-24] [TNL-7318]: BB-2355 - Add decoding and scope verification methods #95

merged 1 commit into from
Aug 13, 2020

Conversation

giovannicimolin
Copy link
Contributor

@giovannicimolin giovannicimolin commented Jul 30, 2020 •
edited
Loading

This PR adds a few token verification mechanisms to support LTI Advantage services.
This is PR 2 of #92.

Testing instructions:
Currently there are no endpoints using this, so just make sure the code is same and checks are passing.

Reviewer:

@openedx-webhooks
Copy link

Thanks for the pull request, @giovannicimolin! I've created BLENDED-527 to keep track of it in Jira. More details are on the BD-24 project page.

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program needs triage labels Jul 30, 2020
@giovannicimolin giovannicimolin mentioned this pull request Jul 30, 2020
Merged
3 tasks
@coveralls
Copy link

coveralls commented Jul 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 97.722% when pulling d10fc8f on open-craft:giovanni/BB-2355-add-decode-token-mechanisms into 60e7de5 on edx:master.

viadanna
viadanna reviewed Aug 5, 2020
View reviewed changes
Copy link
Contributor

@viadanna viadanna left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @giovannicimolin code looks good, just a few questions and nit/typo.

Tests are ongoing and I'll approve it when done.

lti_consumer/lti_1p3/consumer.py Outdated Show resolved Hide resolved
lti_consumer/lti_1p3/consumer.py Outdated Show resolved Hide resolved
lti_consumer/lti_1p3/key_handlers.py Outdated Show resolved Hide resolved
lti_consumer/lti_1p3/key_handlers.py Outdated Show resolved Hide resolved
viadanna
viadanna approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@viadanna viadanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

  • I tested this by running unit tests.
  • I read through the code.

@giovannicimolin giovannicimolin force-pushed the giovanni/BB-2355-add-decode-token-mechanisms branch from 645b297 to d10fc8f Compare August 11, 2020 14:20
@davestgermain davestgermain merged commit 846ccba into openedx:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjoy davidjoy davidjoy approved these changes

@viadanna viadanna viadanna approved these changes

@davestgermain davestgermain davestgermain approved these changes

Assignees
No one assigned
Labels
blended PR is managed through 2U's blended developmnt program merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@giovannicimolin @openedx-webhooks @coveralls @davidjoy @viadanna @davestgermain