-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standardize translation directory for i18n_tool #96
Conversation
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
2782bea
to
0df6e7d
Compare
This PR needs openedx/xblock-submit-and-compare#96 before it's merged. Refs: FC-0012 OEP-58
This PR needs openedx/xblock-submit-and-compare#96 before it's merged. Refs: FC-0012 OEP-58
@OmarIthawi, @brian-smith-tcril this one is ready for your review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this repo has no javascript translations, then this look good to me.
@@ -7,7 +7,6 @@ | |||
|
|||
from unittest import mock | |||
from django.test.client import Client | |||
from django.utils.translation import ugettext as _ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! ugettext
makes no sense in testing. At least, wasn't a good way to test i18n.
Refs: FC-0012 OEP-58
Refs: FC-0012 OEP-58
Refs: FC-0012 OEP-58
0df6e7d
to
4835d0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
This PR needs openedx/xblock-submit-and-compare#96 before it's merged. Refs: FC-0012 OEP-58
This PR needs openedx/xblock-submit-and-compare#96 before it's merged. Refs: FC-0012 OEP-58
feat: standardize translation directory for i18n_tool
This PR prepares the repository to comply with openedx-translations by doing the following:
conf/locale
directory. This is the default used one in openedx-translationsmake extract_translations
build a file nameddjango.po
. This is the entry command used in openedx-translationsi18n
translation in template files + fix a test that fails wheni18n
is enabledTested on local devstack palm to ensure that local translation still worksno local translation exists in this repoReferences
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks