Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockpit: fix metainfo.xml file ownership #220

Conversation

eroullit
Copy link
Contributor

@eroullit eroullit commented May 4, 2020

The tar -cf - | tar -xf combo applies an invalid ownership.
This is corrected by patching the install target to use
the --no-same-owner tar parameter.

Signed-off-by: Emmanuel Roullit [email protected]

Gianfranco Costamagna and others added 9 commits May 3, 2020 14:44
Signed-off-by: Gianfranco Costamagna <[email protected]>
Signed-off-by: Gianfranco Costamagna <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
--enable-zip and --with-libzip were removed in PHP 7.x.
These are replaced by --with-zip --with-zlib-dir.

Signed-off-by: Konrad Weihmann <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Add mbstring to PACKAGECONFIG to enable
multibyte string support in php

Signed-off-by: Konrad Weihmann <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Gianfranco Costamagna <[email protected]>
Signed-off-by: Gianfranco Costamagna <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Signed-off-by: Alistair Francis <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Cockpit is a server manager that makes it easy to
administer your GNU/Linux servers via a web browser.

Signed-off-by: Michael Haener <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
The 'tar -cf - | tar -xf' combo applies an invalid ownership.
This is corrected by patching the install target to use
the --no-same-owner tar parameter.

Signed-off-by: Emmanuel Roullit <[email protected]>
@hoinmic
Copy link
Contributor

hoinmic commented May 5, 2020

@eroullit That's great!
Will you also bring the patch upstream at the cockpit repository?

Copy link
Contributor

@hoinmic hoinmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested patch in combination with #218 . Works.

@eroullit
Copy link
Contributor Author

eroullit commented May 5, 2020

I have double checked a regular install from source on centos 8:

[archie@d47f818d4c65 cockpit-218]$ sudo make install -j 4
[...]
[archie@d47f818d4c65 cockpit-218]$ ls -al /usr/local/share/cockpit/users                                                           
total 224                                                                                                                        
drwxr-xr-x  2 root   root     4096 May  5 19:04 .                                                                                  
drwxr-xr-x 23 root   root     4096 May  5 19:04 ..                                                                               
-rw-r--r--  1 root   root     3222 May  5 19:04 index.html.gz                                                                     
-rw-rw-r--  1 archie archie    751 May  5 18:58 manifest.json                                                            
-rw-r--r--  1 root   root     2605 May  5 19:04 po.ca.js.gz     
[...]

manifest.json should be owned by root, yet it owned by archie.
So yes, this patch should be sent to upstream too.

@kraj
Copy link
Contributor

kraj commented May 8, 2020

fixed with eaf4a9d

@kraj kraj closed this May 8, 2020
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Apr 12, 2022
Version 3.12.2
~~~~~~~~~~~~~~
Released: 2022-04-03
Features:
 * Added support for larger thumbnail sizes: 512, 768 and 1024 pixels.
Bugfixes:
 * Fixed possible crash when changing directory during thumbnails creation.
Translations:

Version 3.12.1
~~~~~~~~~~~~~~
Released: 2022-03-21
Bugfixes:
 * PNG loader ignores gAMA. (openembedded#194)
 * Transparent webp images are rendered incorrectly. (openembedded#199)
 * Crash when dropping files on an empty folder/catalog. (openembedded#220)
 * Fixed location loading after mounting volume.
 * JPEG image dimensions not displayed for files inside the trash. (openembedded#214)
 * Infinite Loop when viewing more than 50 thumbnails. (Kendy Kutzner)
 * X11 window title is not set. (Bruno Vasselle)
 * Copy release notes on build from NEWS to metainfo file. (Federico Bruni)
 * Fixed build if appstream >= 0.14.6 is not available.
 * Fix incorrect usage of shared_module in extensions. (Jakub Jirutka)
 * cli: mention that user can open files and/or directories. (openembedded#167)
Translations

Signed-off-by: Andreas Müller <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
schnitzeltony added a commit to schnitzeltony/meta-openembedded that referenced this pull request Apr 12, 2022
Version 3.12.2
~~~~~~~~~~~~~~
Released: 2022-04-03
Features:
 * Added support for larger thumbnail sizes: 512, 768 and 1024 pixels.
Bugfixes:
 * Fixed possible crash when changing directory during thumbnails creation.
Translations:

Version 3.12.1
~~~~~~~~~~~~~~
Released: 2022-03-21
Bugfixes:
 * PNG loader ignores gAMA. (openembedded#194)
 * Transparent webp images are rendered incorrectly. (openembedded#199)
 * Crash when dropping files on an empty folder/catalog. (openembedded#220)
 * Fixed location loading after mounting volume.
 * JPEG image dimensions not displayed for files inside the trash. (openembedded#214)
 * Infinite Loop when viewing more than 50 thumbnails. (Kendy Kutzner)
 * X11 window title is not set. (Bruno Vasselle)
 * Copy release notes on build from NEWS to metainfo file. (Federico Bruni)
 * Fixed build if appstream >= 0.14.6 is not available.
 * Fix incorrect usage of shared_module in extensions. (Jakub Jirutka)
 * cli: mention that user can open files and/or directories. (openembedded#167)
Translations

Signed-off-by: Andreas Müller <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Apr 14, 2022
Version 3.12.2
~~~~~~~~~~~~~~
Released: 2022-04-03
Features:
 * Added support for larger thumbnail sizes: 512, 768 and 1024 pixels.
Bugfixes:
 * Fixed possible crash when changing directory during thumbnails creation.
Translations:

Version 3.12.1
~~~~~~~~~~~~~~
Released: 2022-03-21
Bugfixes:
 * PNG loader ignores gAMA. (openembedded#194)
 * Transparent webp images are rendered incorrectly. (openembedded#199)
 * Crash when dropping files on an empty folder/catalog. (openembedded#220)
 * Fixed location loading after mounting volume.
 * JPEG image dimensions not displayed for files inside the trash. (openembedded#214)
 * Infinite Loop when viewing more than 50 thumbnails. (Kendy Kutzner)
 * X11 window title is not set. (Bruno Vasselle)
 * Copy release notes on build from NEWS to metainfo file. (Federico Bruni)
 * Fixed build if appstream >= 0.14.6 is not available.
 * Fix incorrect usage of shared_module in extensions. (Jakub Jirutka)
 * cli: mention that user can open files and/or directories. (openembedded#167)
Translations

Signed-off-by: Andreas Müller <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Sep 22, 2023
Changelog
=========
Added:
Add hash capabilities to OUI (openembedded#225, amitmi704)

Fixed:
Backwards incompatible: Handle RFC 6164 IPv6 addresses (don't reserve first IP
address in point-to-point subnets) ($267, Damien Claisse)
Technically backwards incompatible: Fix for is_loopback behaviour – consider
IPNetwork('::1/128') to be loopback (openembedded#222, openembedded#223, niels)
Include tutorials in source distributions (openembedded#215, Louis Sautier)
Fix a documentation typo (openembedded#242, Wouter)
Fix print syntax in the documentation to be Python 3 compatible (openembedded#221, François Magimel)
Fix the Sphinx syntax in the documentation (openembedded#220, François Magimel)

Other:
Update the databases (openembedded#266, Jakub Stasiak)
Deprecate Python 3.6 (openembedded#263, Jakub Stasiak)
Eliminate unnecessary evals (openembedded#228, KOLANICH)

Signed-off-by: Derek Straka <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Oct 23, 2023
Changelog:
===========
Feature
--------
Update for final cpython release (openembedded#263) (460a072)
Speed up unpacking arrays (openembedded#257) (5c8bfe5)
Speed up constructing Variant objects (openembedded#256) (0d7a665)
Speed up unmarshalling message body (openembedded#255) (5aed075)
Speed up unmarshalling Variants (openembedded#254) (dd74a84)
Speed up readers in the unmarshall path (openembedded#253) (f9b61b8)
Speed up first connection when using asyncio (openembedded#251) (0b6ba93)
Speed up unmarshaller (openembedded#250) (e4cae13)
Add cython typing for ServiceInterface.name (openembedded#248) (98c7e75)
Speed up connect and disconnect (openembedded#247) (8f39ba3)
Speed up unmarshalling by skipping unused unix_fds header (openembedded#246) (5f5a150)
Reduce overhead to reset between messages (openembedded#245) (da30b04)
Don't import backends by default (openembedded#243) (091d421)
Breaking
don't import backends by default (openembedded#243) (091d421)
Small speed up to the unmarshaller (openembedded#238) (b8d0e9b)
Build cpython 3.12 wheels (openembedded#234) (b38aa58)
Improve performance of processing incoming messages (openembedded#228) (ce61aea)
Reduce overhead to dispatch method handlers (openembedded#227) (b222552)
Speed up to processing bluez passive data (openembedded#221) (8e7432d)
Remove async_timeout dependency (openembedded#218) (7826897)
Speed up Message creation and callbacks (openembedded#217) (04d6451)
Optimize passive bluez message unmarshaller (openembedded#216) (e0e87ec)
Initial cpython 3.12 support (openembedded#207) (c755193)
Improve performance of reading from the socket during unmarshall (openembedded#200) (e5d355f)

Fix
-------------
Handling of None messages from notify callback (openembedded#236) (14f52f2)
Clean up address parsing and tests (openembedded#244) (370791d)
Handle multiple flag bits when unmarshalling (openembedded#241) (6f6f5f8)
Rebuild wheels with cython 3.0.2 (openembedded#235) (e8901a8)
Avoid cythonizing SendReply (openembedded#232) (d12266d)
Subpath bad matching (openembedded#202) (5d6f90b)
Messages could be sent out of order if they had to queue (openembedded#225) (4051cf2)
Avoid checking if a message expects a reply twice (openembedded#223) (823e85f)
Revert changes to _expects_reply from speed up to processing bluez passive data (openembedded#222) (dfa9053)
Spelling of dbus_fast.auth.AuthAnnonymous to dbus_fast.auth.AuthAnonymous (openembedded#220) (6c2412f)
More cython3 optional fixes (openembedded#219) (5b6cbc5)
Exception handler failure when exception is not DBusError (openembedded#215) (d771bcf)
Result typing in ServiceInterface._handle_signal (openembedded#214) (5bda04b)
Avoid double buffering when using asyncio reader without negotiate_unix_fd (openembedded#213) (c933be7)
Relax typing on _fn_result_to_body to allow Any (openembedded#212) (2f5fc38)
Typing on _fn_result_to_body was incorrect which was caused an exception with cython3 (openembedded#210) (c40c7bc)
Cython3 compat (openembedded#208) (43b3d48)
Reduce size of wheels by excluding generated .c files (openembedded#262) (dca4599)
Marshall multi-byte strings correctly (openembedded#261) (4de31a3)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
halstead pushed a commit that referenced this pull request Nov 3, 2023
Changelog:
===========
Feature
--------
Update for final cpython release (#263) (460a072)
Speed up unpacking arrays (#257) (5c8bfe5)
Speed up constructing Variant objects (#256) (0d7a665)
Speed up unmarshalling message body (#255) (5aed075)
Speed up unmarshalling Variants (#254) (dd74a84)
Speed up readers in the unmarshall path (#253) (f9b61b8)
Speed up first connection when using asyncio (#251) (0b6ba93)
Speed up unmarshaller (#250) (e4cae13)
Add cython typing for ServiceInterface.name (#248) (98c7e75)
Speed up connect and disconnect (#247) (8f39ba3)
Speed up unmarshalling by skipping unused unix_fds header (#246) (5f5a150)
Reduce overhead to reset between messages (#245) (da30b04)
Don't import backends by default (#243) (091d421)
Breaking
don't import backends by default (#243) (091d421)
Small speed up to the unmarshaller (#238) (b8d0e9b)
Build cpython 3.12 wheels (#234) (b38aa58)
Improve performance of processing incoming messages (#228) (ce61aea)
Reduce overhead to dispatch method handlers (#227) (b222552)
Speed up to processing bluez passive data (#221) (8e7432d)
Remove async_timeout dependency (#218) (7826897)
Speed up Message creation and callbacks (#217) (04d6451)
Optimize passive bluez message unmarshaller (#216) (e0e87ec)
Initial cpython 3.12 support (#207) (c755193)
Improve performance of reading from the socket during unmarshall (#200) (e5d355f)

Fix
-------------
Handling of None messages from notify callback (#236) (14f52f2)
Clean up address parsing and tests (#244) (370791d)
Handle multiple flag bits when unmarshalling (#241) (6f6f5f8)
Rebuild wheels with cython 3.0.2 (#235) (e8901a8)
Avoid cythonizing SendReply (#232) (d12266d)
Subpath bad matching (#202) (5d6f90b)
Messages could be sent out of order if they had to queue (#225) (4051cf2)
Avoid checking if a message expects a reply twice (#223) (823e85f)
Revert changes to _expects_reply from speed up to processing bluez passive data (#222) (dfa9053)
Spelling of dbus_fast.auth.AuthAnnonymous to dbus_fast.auth.AuthAnonymous (#220) (6c2412f)
More cython3 optional fixes (#219) (5b6cbc5)
Exception handler failure when exception is not DBusError (#215) (d771bcf)
Result typing in ServiceInterface._handle_signal (#214) (5bda04b)
Avoid double buffering when using asyncio reader without negotiate_unix_fd (#213) (c933be7)
Relax typing on _fn_result_to_body to allow Any (#212) (2f5fc38)
Typing on _fn_result_to_body was incorrect which was caused an exception with cython3 (#210) (c40c7bc)
Cython3 compat (#208) (43b3d48)
Reduce size of wheels by excluding generated .c files (#262) (dca4599)
Marshall multi-byte strings correctly (#261) (4de31a3)

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
(cherry picked from commit f10cf13)
Signed-off-by: Armin Kuster <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants