Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove PNBLACKLIST for can-isotp module #303

Closed

Conversation

jinparksj
Copy link

Like I described in Issue for dunfell,

  1. Remove PNBLACKLIST for can-isotp module
  2. Move git branch to 4.17+ in can-isotp git repo
  3. Revert commit id to 41835f3 to avoid another conflict with kernel 5.10+

move branch to 4.17+ in can-isotp git repo
revert commit id to 41835f3
@kraj
Copy link
Contributor

kraj commented Dec 24, 2020

it fails with 5.8 kernel see https://errors.yoctoproject.org/Errors/Details/540250/

Keep master branch at current can-isotp
@jinparksj
Copy link
Author

I change the recipe like below again and push it again.

  1. Remove PNBLACKLIST
  2. Keep same master branch for can-isotp, not changing to new branch 4.17 and not reverting back the commit ID

@kraj
Copy link
Contributor

kraj commented Dec 25, 2020

I change the recipe like below again and push it again.

  1. Remove PNBLACKLIST
  2. Keep same master branch for can-isotp, not changing to new branch 4.17 and not reverting back the commit ID

have you tested it build on qemuarm or any other qemu machines ?

@kraj
Copy link
Contributor

kraj commented Dec 26, 2020

@akuster can you take care of this for dunfell ?

@jinparksj
Copy link
Author

I didn't test it with any qemu machines. I tested only Variscite board with linux kernel 5.4 version. I will check it with qemu machines.

@kraj
Copy link
Contributor

kraj commented Jan 10, 2021

any updates @jinparksj

@akuster
Copy link
Contributor

akuster commented Jan 15, 2021

So is seems backporting the "weak assignment" that is in Gatesgarth
https://git.openembedded.org/meta-openembedded/commit/meta-oe/recipes-extended/socketcan/can-isotp_git.bb?h=gatesgarth&id=d7f5367b53f6fd410e1ebb270f52c2d9f4b3435a

should allow overriding.

is this what the ask is here?

@kraj
Copy link
Contributor

kraj commented Jan 15, 2021

I think so

@jinparksj
Copy link
Author

I am sorry for belated response.
Under 'qemuarm' and 'dunfell' conditions, it was fine to bake and runqemu like below.

jin@jin-ThinkPad-P51:~/poky/build$ bitbake core-image-full-cmdline
Parsing recipes: 100% |##########################################| Time: 0:00:24
Parsing of 1531 .bb files complete (0 cached, 1531 parsed). 2310 targets, 111 skipped, 0 masked, 0 errors.
NOTE: Resolving any missing task queue dependencies

Build Configuration:
BB_VERSION = "1.46.0"
BUILD_SYS = "x86_64-linux"
NATIVELSBSTRING = "universal"
TARGET_SYS = "arm-poky-linux-gnueabi"
MACHINE = "qemuarm"
DISTRO = "poky"
DISTRO_VERSION = "3.1.5"
TUNE_FEATURES = "arm armv7ve vfp thumb neon callconvention-hard"
TARGET_FPU = "hard"
meta
meta-poky
meta-yocto-bsp = "dunfell:e32d854e33bc86c2a616df8708e021a098afcf73"
meta-oe = "dunfell:f2d02cb71eaff8eb285a1997b30be52486c160ae"

Initialising tasks: 100% |#######################################| Time: 0:00:01
Sstate summary: Wanted 662 Found 0 Missed 662 Current 766 (0% match, 53% complete)
NOTE: Executing Tasks
NOTE: Tasks Summary: Attempted 3773 tasks of which 2338 didn't need to be rerun and all succeeded.
jin@jin-ThinkPad-P51:~/poky/build$

jin@jin-ThinkPad-P51:~/poky/build$ runqemu qemuarm core-image-full-cmdline
runqemu - INFO - Running MACHINE=qemuarm bitbake -e ...
runqemu - INFO - Continuing with the following parameters:
KERNEL: [/home/jin/poky/build/tmp/deploy/images/qemuarm/zImage--5.4.85+git0+1c358e1969_888fe3a6f7-r0-qemuarm-20210119030130.bin]
MACHINE: [qemuarm]
FSTYPE: [ext4]
ROOTFS: [/home/jin/poky/build/tmp/deploy/images/qemuarm/core-image-full-cmdline-qemuarm.ext4]
CONFFILE: [/home/jin/poky/build/tmp/deploy/images/qemuarm/core-image-full-cmdline-qemuarm.qemuboot.conf]

@halstead halstead closed this in e5bbf13 Feb 5, 2021
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Jan 4, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Jan 4, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Jan 5, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Jan 6, 2023
Changelog:
==========
- Fix regression (openembedded#310)
- Merge pull request openembedded#303 from rsnapshot/update-HOWTO-to-talk-about-retain-instead-of-interval
- Removing legacy Docbook files, as per discussion at rsnapshot/rsnapshot#296
- Merge pull request openembedded#296 from hoclun-rigsep/hoclun-rigsep-patch-1
- Use @Prefix@ instead of hardcoded value in rsnapshot.conf.default.in comment line (openembedded#289).

Signed-off-by: Wang Mingyu <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Aug 19, 2024
- switch to meson build system

Changelog [1]:

$ git --no-pager log --oneline v1.0.4..v1.0.5
098d985 (tag: v1.0.5) Merge pull request openembedded#312 from cgwalters/release
0fae8a8 Release 1.0.5
9bdc377 Merge pull request openembedded#310 from cgwalters/symlink-limit
b06ea9b Verify payload length early on
3beb011 Merge pull request openembedded#308 from cgwalters/minor-rust-lints
a695ad4 Merge pull request openembedded#309 from giuseppe/libcomposefs-drop-ro
0a0d50f libcomposefs: drop using "ro" option
b35dc83 dumpfile: Fix clippy lint
a919ab8 rust: Drop unused cfg
3a87868 Merge pull request openembedded#307 from giuseppe/not-override-errno
bb94687 Merge pull request openembedded#306 from giuseppe/mkcomposefs-report-close-errors
76b4da5 mkcompose: report close() errors
502bc27 libcomposefs: do not override errno
2d2c09d Merge pull request openembedded#304 from jluebbe/meson
0260856 meson.build: Allow use as a meson subproject
5f512ac Merge pull request openembedded#303 from cgwalters/mount-source
91a3047 mount: Consistently use `composefs` as source
45e6179 Merge pull request openembedded#302 from cgwalters/info-term
f64022f info: Add missing terminator for `longopts`
d81cb87 Merge pull request openembedded#300 from jluebbe/meson
04c8a8e ci: Add GitHub Actions workflow which uses meson
64709f6 ci: Install meson package
b6f2b75 Add meson as an alternative to autotools
942cd73 Merge pull request openembedded#299 from giuseppe/composefs-info-set-locale
5072fd7 composefs-info: specify locale to isgraph/isprint
4f19d00 Merge pull request openembedded#298 from cgwalters/rust-misc
43a1d28 rust: Add README.md files, link to crates.io
a8bc747 rust: Clarify that "composefs-core" is really "composefs"
483356c Merge pull request openembedded#297 from cgwalters/rust-include
02213c0 composefs-core: Drop incorrect `include`
dce84ff Merge pull request openembedded#295 from cgwalters/rust-descr
3d2af03 Merge pull request openembedded#296 from Kiskae/upstream-tmpdir-fix
6928fcf test: remove hardcoded /tmp
e21be07 rust: Add mandatory `description` field, other misc changes
28dc491 Merge pull request openembedded#292 from cgwalters/rust-ci-dual
59c5a27 Merge pull request openembedded#293 from cgwalters/rust-minor
689ccc6 rust: Some doc and misc tweaks
426b65d ci: Test Rust code against current C code
32b3f6e Merge pull request openembedded#291 from Kiskae/patch-1
f7465b3 use correct `composefs-info` binary

[1] containers/composefs@v1.0.4...v1.0.5

Signed-off-by: Jose Quaresma <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Aug 19, 2024
- switch to meson build system

Changelog [1]:

$ git --no-pager log --oneline v1.0.4..v1.0.5
098d985 (tag: v1.0.5) Merge pull request openembedded#312 from cgwalters/release
0fae8a8 Release 1.0.5
9bdc377 Merge pull request openembedded#310 from cgwalters/symlink-limit
b06ea9b Verify payload length early on
3beb011 Merge pull request openembedded#308 from cgwalters/minor-rust-lints
a695ad4 Merge pull request openembedded#309 from giuseppe/libcomposefs-drop-ro
0a0d50f libcomposefs: drop using "ro" option
b35dc83 dumpfile: Fix clippy lint
a919ab8 rust: Drop unused cfg
3a87868 Merge pull request openembedded#307 from giuseppe/not-override-errno
bb94687 Merge pull request openembedded#306 from giuseppe/mkcomposefs-report-close-errors
76b4da5 mkcompose: report close() errors
502bc27 libcomposefs: do not override errno
2d2c09d Merge pull request openembedded#304 from jluebbe/meson
0260856 meson.build: Allow use as a meson subproject
5f512ac Merge pull request openembedded#303 from cgwalters/mount-source
91a3047 mount: Consistently use `composefs` as source
45e6179 Merge pull request openembedded#302 from cgwalters/info-term
f64022f info: Add missing terminator for `longopts`
d81cb87 Merge pull request openembedded#300 from jluebbe/meson
04c8a8e ci: Add GitHub Actions workflow which uses meson
64709f6 ci: Install meson package
b6f2b75 Add meson as an alternative to autotools
942cd73 Merge pull request openembedded#299 from giuseppe/composefs-info-set-locale
5072fd7 composefs-info: specify locale to isgraph/isprint
4f19d00 Merge pull request openembedded#298 from cgwalters/rust-misc
43a1d28 rust: Add README.md files, link to crates.io
a8bc747 rust: Clarify that "composefs-core" is really "composefs"
483356c Merge pull request openembedded#297 from cgwalters/rust-include
02213c0 composefs-core: Drop incorrect `include`
dce84ff Merge pull request openembedded#295 from cgwalters/rust-descr
3d2af03 Merge pull request openembedded#296 from Kiskae/upstream-tmpdir-fix
6928fcf test: remove hardcoded /tmp
e21be07 rust: Add mandatory `description` field, other misc changes
28dc491 Merge pull request openembedded#292 from cgwalters/rust-ci-dual
59c5a27 Merge pull request openembedded#293 from cgwalters/rust-minor
689ccc6 rust: Some doc and misc tweaks
426b65d ci: Test Rust code against current C code
32b3f6e Merge pull request openembedded#291 from Kiskae/patch-1
f7465b3 use correct `composefs-info` binary

[1] containers/composefs@v1.0.4...v1.0.5

Signed-off-by: Jose Quaresma <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants