ntp: fix ntpdate to wait for subprocesses #387

azaharia-wr · 2021-06-28T09:22:27Z

When using systemd, ntpdate-sync script will start in background
triggering the start of ntpd without actually exiting.
This results in an bind error in ntpd startup.

Add wait at the end of ntpdate script to ensure that when the ntpdate.service
is marked as finished the oneshot script ntpdate-sync finished and unbind the
ntp port

Fixes #386

Signed-off-by: Adrian Zaharia [email protected]

When using systemd, ntpdate-sync script will start in background triggering the start of ntpd without actually exiting. This results in an bind error in ntpd startup. Add wait at the end of ntpdate script to ensure that when the ntpdate.service is marked as finished the oneshot script ntpdate-sync finished and unbind the ntp port Fixes openembedded#386 Signed-off-by: Adrian Zaharia <[email protected]>

raulmont · 2021-06-29T09:58:20Z

Validated with systemd-analyze plot > /tmp/systemd_plot.svg

kraj · 2021-06-29T16:16:27Z

Validated with systemd-analyze plot > /tmp/systemd_plot.svg

thanks for applying additional testing. really appreciated

kraj · 2021-06-30T06:07:20Z

this is in master now.

License-Update : license check file changed from LICENSE to LICENSE.rst Changelog from 0.15.1 to 1.0.1: =============================== Update compatibility with the latest Werkzeug release. openembedded#511 Deprecated items removal openembedded#484 Support for alternatives captcha services openembedded#425 openembedded#342 openembedded#387 openembedded#384 Signed-off-by: Zheng Ruoqin <[email protected]> Signed-off-by: Khem Raj <[email protected]>

License-Update : license check file changed from LICENSE to LICENSE.rst Changelog from 0.15.1 to 1.0.1: =============================== Update compatibility with the latest Werkzeug release. #511 Deprecated items removal #484 Support for alternatives captcha services #425 #342 #387 #384 Signed-off-by: Zheng Ruoqin <[email protected]> Signed-off-by: Khem Raj <[email protected]>

License-Update : license check file changed from LICENSE to LICENSE.rst Changelog from 0.15.1 to 1.0.1: =============================== Update compatibility with the latest Werkzeug release. openembedded#511 Deprecated items removal openembedded#484 Support for alternatives captcha services openembedded#425 openembedded#342 openembedded#387 openembedded#384 Signed-off-by: Zheng Ruoqin <[email protected]> Signed-off-by: Khem Raj <[email protected]>

License-Update : license check file changed from LICENSE to LICENSE.rst Changelog from 0.15.1 to 1.0.1: =============================== Update compatibility with the latest Werkzeug release. #511 Deprecated items removal #484 Support for alternatives captcha services #425 #342 #387 #384 Signed-off-by: Zheng Ruoqin <[email protected]> Signed-off-by: Khem Raj <[email protected]>

@mtitinger

…325338b6e7b3d42de) Drop patches now part of new upstream release: - 0001-Fix-memory-leak.patch - 0001-cmake-Link-with-libatomic-on-rv32-rv64.patch - 0001-dlt-system-Fix-buffer-overflow-detection-on-32bit-ta.patch Cherry-pick and propose upstream two patches to fix build failures with security hardening flags enabled and with some systemd configuration (underlink) - 481.patch - 482.patch Add new dlt-adaptor-stdin cmake optional flag Drop PV variable, not needed anymore Drop latomic manual added flag, upstream code changed to avoid its need See: COVESA/dlt-daemon#433 and COVESA/dlt-daemon@2224cdd (changed from atomic_bool to atomic_int, the latter doesn't require manual atomic library link since it can be optimized properly by the compiler on riscv platforms) What's Changed: dlt-system: fix a libc buffer overflow detection on 32bit targets by @mtitinger in openembedded#337 dlt-daemon: create sockets using "android way" by @sebastienraillet in openembedded#333 fixes compilation issue with clang by @sebastienraillet in openembedded#339 dlt-daemon: Only create directories if they do not exist yet by @alexmohr in openembedded#340 dlt-system : fix invalid free with ConfigurationFileName by @mtitinger in openembedded#342 fix for the issue openembedded#341 by @rvalovyi in openembedded#347 Forcibly the severity level set by @dhnatiuk1 in openembedded#346 fix -Wformat issues reported by clang by @sebastienraillet in openembedded#349 dlt-system: fix invalid free by removing unused TempDir by @andreirusu96 in openembedded#350 Support for Cygwin toolchain. by @DoctorNoobingstoneIPresume in openembedded#351 filetransfer: Return error if no free space by @ssugiura in openembedded#354 lib: Correct VARI usage in dlt_user_log_write_uint by @ssugiura in openembedded#356 Fix DLT User/Client tests by @andreirusu96 in openembedded#357 tests: Deplicate unused files and variables by @ssugiura in openembedded#359 Fix the target name in documentation by @mawillers in openembedded#372 cmake: Add option to enable each adaptor by itself by @alexmohr in openembedded#364 cmake: Add options to enable/disable each dlt console tool by @alexmohr in openembedded#363 filetransfer: Fix getFileCreationDate2 stat check by @andreirusu96 in openembedded#361 dlt_config_file_parser.c：Fix a pointer release bug in the file。 by @Leslie-bcy in openembedded#376 Update workflow by @thanhbnq in openembedded#389 README: Update link to github actions by @ssugiura in openembedded#392 Fix handle returned value by @thanhbnq in openembedded#384 systemd: install adaptor-udp service for adaptor=on by @danielweber2018 in openembedded#393 automotive-dlt.pc: add the path to find the static library by @zeerd in openembedded#387 enforce-trace-limit: ContextLogLevel is now enforced in the daemon by @alexmohr in openembedded#382 dlt-daemon-connection: Start up even if not all bindings are valid by @alexmohr in openembedded#380 dlt_common.c: Change default logging_mode by @wusto in openembedded#406 logstorage: Truncate ECUid in Logstorage filter to prevent crash by @andreirusu96 in openembedded#402 Update dlt_for_developers.md by @marques-bruno in openembedded#405 dlt-gateway: Fix crash on invalid ip by @alexmohr in openembedded#381 dlt_client:Block in connect() by @thanhbnq in openembedded#409 dlt_daemon_client: Fix change loglevel of application by @lti9hc in openembedded#408 Update maintainer by @thanhbnq in openembedded#410 systemd: add support for socket activation via systemd by @alexmohr in openembedded#401 internal-logging: Fix issues with file logging by @alexmohr in openembedded#378 dlt_common: change output of message for log initialization by @lti9hc in openembedded#412 Avoid memory corruption behind buffer wp in function dlt_getloginfo_conv_ascii_to_id by @michael-methner in openembedded#411 dlt_daemon_client: Fix Control Msg ECUId comparison with active Gateway by @andreirusu96 in openembedded#414 Fix for Resource and Memory Leak by @lti9hc in openembedded#418 dlt-receive: set host interface and allow multiple udp multicast addresses by @thanhbnq in openembedded#420 dlt-system: Fix buffer overflow detection on 32bit targets by @sandy-lcq in openembedded#398 cmake: network trace enable toggle by @danielweber2018 in openembedded#424 client: Fix Get Log Info response conversion method by @andreirusu96 in openembedded#422 filetransfer: fix filesize divisible by blocksize case by @danielweber2018 in openembedded#383 Updates for Coding Styles by @thanhbnq in openembedded#425 gateway: Fix Node handling and ECUid checks by @andreirusu96 in openembedded#429 Update contacts and removed mailing lists by @michael-methner in openembedded#431 dlt-user: Fix crashes in dlt_free during dlt_init by @alexmohr in openembedded#362 dlt-convert: Fix memory leak by calling dlt_file_free by @lvklevankhanh in openembedded#434 dlt-user: fix potential non closed socket in init/free by @alexmohr in openembedded#435 Check for negative index in dlt_file_message by @michael-methner in openembedded#437 Fix memory leak by @lvklevankhanh in openembedded#441 dlt-connection: add socket timeout by @alexmohr in openembedded#439 Installs dlt.conf on android by @sebastienraillet in openembedded#446 This changes a mispatch from fcb676a to install udp binary correctly by @smooge in openembedded#449 logfile: exhance internal dlt logging by introducing size limits by @danielweber2018 in openembedded#369 dlt-logd-converter: fixes android 12 compilation by @sebastienraillet in openembedded#445 dlt-logd-converter: Fix getting log level from log msg by @RobinChenJP in openembedded#456 house-keeper: remove infinite wait by @alexmohr in openembedded#438 cmake: remove duplicated option message by @minminlittleshrimp in openembedded#454 Android: Add new feature in Android bp by @minminlittleshrimp in openembedded#461 dlt_multiple_files: remove superfluous mode bits and add header file to header list by @minminlittleshrimp in openembedded#462 dlt-user: fix crash with certain strings by @alexmohr in openembedded#463 Signed-off-by: Gianfranco Costamagna <[email protected]> Signed-off-by: Gianfranco Costamagna <[email protected]> Signed-off-by: Khem Raj <[email protected]>

Overview of changes in gnome-calculator 47.0 * Updated translations * Fixed flatpak build !181 (Hari Rana) * Don't use symbolic icons for the window !182 (Balló György) Overview of changes in gnome-calculator 47.rc * Updated translations * Added brand colors !178 (Brage Fuglseth) Overview of changes in gnome-calculator 47.beta * Updated translations * Fix hex string conversion for bitwise operator !177 (Xiong Nandi) * Force LTR for buttons !171 (Khalid Abu Shawarib) * Added kWh, MJ, KJ unit support openembedded#417 (Robert Roth) * Sort conversion categories alphabetically openembedded#395 (Robert Roth) * Removed obsolete bulgarian translations openembedded#402 (Robert Roth) * Only allow alphanumeric values for variable names openembedded#396 (Robert Roth) * Replace base_label with buttons !173 (Clément Mathieu--Drif) * Updated flathub badge !174 (Brage Fuglseth) * Use adwaita spinner !175 (Cristopher Davis) Overview of changes in gnome-calculator 47.alpha * Updated translations * Support VND currency openembedded#387 (Robert Roth) * Fixed incorrect event handling openembedded#392 (Robert Roth) * Removed Shift left/right dropdown openembedded#330 (Robert Roth) * Improved popover remove buttons openembedded#401 (Robert Roth) * Use result format instead of number format openembedded#399 (Robert Roth) * Ported to Adwaita adaptive dialogs (Robert Roth) * Disable undo button if nothing to undo openembedded#280 (Robert Roth) * Metainfo improvements (Andre Klapper) * Keep last conversion options at launch openembedded#351 (Robert Roth) * Minor improvements to the undo button !166 (Automeris naranja) * Make sure to use the correct app id for development builds !170 (Christopher Davis) * Stop using orange accent color !169 (Alice Mikhaylenko) * A11y announce status changes !172 (Lukáš Tyrychtr) Signed-off-by: Markus Volk <[email protected]> Signed-off-by: Khem Raj <[email protected]>

raulmont approved these changes Jun 29, 2021

View reviewed changes

kraj closed this Jun 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ntp: fix ntpdate to wait for subprocesses #387

ntp: fix ntpdate to wait for subprocesses #387

azaharia-wr commented Jun 28, 2021

raulmont commented Jun 29, 2021

kraj commented Jun 29, 2021

kraj commented Jun 30, 2021

ntp: fix ntpdate to wait for subprocesses #387

ntp: fix ntpdate to wait for subprocesses #387

Conversation

azaharia-wr commented Jun 28, 2021

raulmont commented Jun 29, 2021

kraj commented Jun 29, 2021

kraj commented Jun 30, 2021