Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExprTk: Update package to release/0.0.2 #657

Closed
wants to merge 1 commit into from
Closed

ExprTk: Update package to release/0.0.2 #657

wants to merge 1 commit into from

Conversation

ArashPartow
Copy link
Contributor

@ArashPartow ArashPartow commented Feb 16, 2023 •
edited
Loading

Updates include:

  1. Runtime checks to expression
  2. Stackoverflow protections during compilation and expression evaluation
  3. Various evaluation performance improvements

@ArashPartow
Copy link
Contributor Author

@kraj when you have a moment can you please review and merge this PR

kraj
kraj reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patch. It looks ok, except that patch subject should follow the commit guidelines [1], see section Patch Headers and Commit Messages

[1] https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

@ArashPartow ArashPartow changed the title Update ExprTk package to release/0.0.2 ExprTk: Update package to release/0.0.2 Feb 16, 2023
@ArashPartow
Copy link
Contributor Author

@kraj I've updated the commit message and added some notes

@geissonator
Copy link
Contributor

Ahh, we just hit this over in openbmc. Did we lost the previous commit (force push into master?) We can't build the previous recipe anymore.

@shr-project
Copy link
Contributor

shr-project commented Feb 17, 2023 •
edited
Loading

Looks like the commit really disappeared :( force pushing to publicly consumed branch is bad practice (I do it all the time for my personal branches, but nobody should be using them from upstream).

martin@jama /OE/exprtk $ git branch -a --contains 281c2ccc65b8f91c012ea3725ebcef406378a225
error: no such commit 281c2ccc65b8f91c012ea3725ebcef406378a225

martin@jama /OE/exprtk $ git branch -a --contains f46bffcd6966d38a09023fb37ba9335214c9b959
* master
  remotes/origin/HEAD -> origin/master
  remotes/origin/master
  remotes/origin/release

I was curious what changed and as I still had old version of master on PREMIRROR I've forked it and pushed as old-master:
https://github.com/ArashPartow/exprtk/compare/master...shr-project:exprtk:old-mster?expand=1

@geissonator that's why PREMIRRORs (and their snapshots) are pretty much mandatory for any serious project with reproducible builds.

@kraj
Copy link
Contributor

kraj commented Feb 17, 2023

I usually cherry-pick from github PRs into master-next for CI purpose, so its there on master-next https://git.openembedded.org/meta-openembedded/log/?h=master-next

Can you check if its still the same ?

@geissonator
Copy link
Contributor

Fix over in master-next at https://git.openembedded.org/meta-openembedded/commit/?h=master-next&id=98323c08a76cf54d0dd6a0c279c3c3e14494c04a looks good to me. Thanks!

@ArashPartow
Copy link
Contributor Author

Apologies all for the confusion. The release branch is intended to be clean and will not have force pushes done on it. I also agree with @shr-project that snapshots are a good idea for reproducible build use-cases.

@kraj
Copy link
Contributor

kraj commented Feb 23, 2023

This is now in master - 0522e66

@kraj kraj closed this Feb 23, 2023
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this pull request Dec 19, 2023
@akiernan @kraj
c-ares: Upgrade 1.22.1 -> 1.24.0
6459e1f 
Use PACKAGE_BEFORE_PN which is designed to introduce packages before the
final greedy ${PN}.

Changes 1.24.0:

Brad House (28):
      Nameserver parsing: replace another hand-written parser (openembedded#643)
      clang-format
      SonarCloud: silence bogus reported error
      ares_init_options() with invalid options values should unset the option
      Enable system extensions
      try to move AC_USE_SYSTEM_EXTENSIONS
      ares__round_up_pow2() work around bogus warning
      silence openwatcom warning due to qcache_max_ttl being unsigned
      Support ipv6 link-local servers and %iface syntax (openembedded#646)
      Windows UBSAN tests (openembedded#649)
      increment failures on timeout (openembedded#651)
      SonarCloud: make const
      enhance timeout test case
      enhance timeout test case to make sure it will re-use a previously downed server
      Rewrite sortlist hand parser for memory safety and bugs (openembedded#653)
      Clean up some Windows-only warnings (openembedded#654)
      clang-format and fix one warning
      remove redundant cast
      use IF_NAMESIZE instead of IFNAMSIZ to avoid warning
      Use external GoogleTest instead of bundling it (openembedded#655)
      remove dead code: bitncmp
      remove dead code: ares_iphlpapi.h
      Coverity: fix allocation size as reported in new code
      tag some functions as deprecated in docs
      reference alternative to ares_getsock() in docs
      1.24.0 release prep (openembedded#657)
      rand: allow fallback from OS (openembedded#661)
      ares_cancel() could trigger callback with wrong response code (openembedded#663)

Changes 1.23.0:

Brad House (21):
      Query Cache support (openembedded#625)
      ares_set_servers_*() should allow an empty server list
      Fix Windows UWP (Store) building and add to CI/CD (openembedded#627)
      clang-format
      cleanup some Windows warnings in test
      fix additional windows test warnings
      CMake: CXXFLAGS environment wasn't being read because C++ compiler was enabled after settings warnings.
      now that warnings are enabled on test cases, clear a bunch of warnings
      fix test case regression due to missing parens
      SonarCloud: fix minor codesmells
      more precise timeout calculation (openembedded#633)
      environment is meant as an override for sysconfig
      Fix MacOS version test
      Basic Thread Safety (openembedded#636)
      fix ares_threadsafety() prototype
      ares_init_options with ARES_OPT_UDP_PORT wrong byte order
      fix doc typo
      remove a simply
      clang-format
      add missing manpage to distribution list
      1.23.0 release prep (openembedded#641)

Christian Clauss (2):
      INSTALL.md: Fix typo (openembedded#630)
      Fix typos discovered by codespell (openembedded#634)

Daniel Stenberg (1):
      CI: codespell

Ignat (1):
      Support attempts and timeout options from resolv.conf (openembedded#632)

petrvh (1):
      ares_getaddrinfo(): do not use search domains if ARES_FLAG_NOSEARCH is set (openembedded#638)

Signed-off-by: Alex Kiernan <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
halstead pushed a commit that referenced this pull request Dec 20, 2023
@akiernan @kraj
c-ares: Upgrade 1.22.1 -> 1.24.0
10f1890 
Use PACKAGE_BEFORE_PN which is designed to introduce packages before the
final greedy ${PN}.

Changes 1.24.0:

Brad House (28):
      Nameserver parsing: replace another hand-written parser (#643)
      clang-format
      SonarCloud: silence bogus reported error
      ares_init_options() with invalid options values should unset the option
      Enable system extensions
      try to move AC_USE_SYSTEM_EXTENSIONS
      ares__round_up_pow2() work around bogus warning
      silence openwatcom warning due to qcache_max_ttl being unsigned
      Support ipv6 link-local servers and %iface syntax (#646)
      Windows UBSAN tests (#649)
      increment failures on timeout (#651)
      SonarCloud: make const
      enhance timeout test case
      enhance timeout test case to make sure it will re-use a previously downed server
      Rewrite sortlist hand parser for memory safety and bugs (#653)
      Clean up some Windows-only warnings (#654)
      clang-format and fix one warning
      remove redundant cast
      use IF_NAMESIZE instead of IFNAMSIZ to avoid warning
      Use external GoogleTest instead of bundling it (#655)
      remove dead code: bitncmp
      remove dead code: ares_iphlpapi.h
      Coverity: fix allocation size as reported in new code
      tag some functions as deprecated in docs
      reference alternative to ares_getsock() in docs
      1.24.0 release prep (#657)
      rand: allow fallback from OS (#661)
      ares_cancel() could trigger callback with wrong response code (#663)

Changes 1.23.0:

Brad House (21):
      Query Cache support (#625)
      ares_set_servers_*() should allow an empty server list
      Fix Windows UWP (Store) building and add to CI/CD (#627)
      clang-format
      cleanup some Windows warnings in test
      fix additional windows test warnings
      CMake: CXXFLAGS environment wasn't being read because C++ compiler was enabled after settings warnings.
      now that warnings are enabled on test cases, clear a bunch of warnings
      fix test case regression due to missing parens
      SonarCloud: fix minor codesmells
      more precise timeout calculation (#633)
      environment is meant as an override for sysconfig
      Fix MacOS version test
      Basic Thread Safety (#636)
      fix ares_threadsafety() prototype
      ares_init_options with ARES_OPT_UDP_PORT wrong byte order
      fix doc typo
      remove a simply
      clang-format
      add missing manpage to distribution list
      1.23.0 release prep (#641)

Christian Clauss (2):
      INSTALL.md: Fix typo (#630)
      Fix typos discovered by codespell (#634)

Daniel Stenberg (1):
      CI: codespell

Ignat (1):
      Support attempts and timeout options from resolv.conf (#632)

petrvh (1):
      ares_getaddrinfo(): do not use search domains if ARES_FLAG_NOSEARCH is set (#638)

Signed-off-by: Alex Kiernan <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraj kraj kraj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArashPartow @geissonator @shr-project @kraj