feat: Weno improve design, and pharmacy import speed #7204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve pharmacy import by using transactional queries. From 4 minutes to 40 seconds. - improve validation and error reporting. - some code cleanup for warnings and in general - fix frame screen output to use the current theme so user always see content.
stephenwaite
reviewed
Feb 2, 2024
| @@ -1,6 +1,6 @@ | |||
| <?php | |||
|
|
|||
| /* | |||
| /** | |||
sjpadgett
commented
Feb 2, 2024
Comment on lines
+197
to
+198
| sqlStatementNoLog('COMMIT'); | ||
| sqlStatementNoLog('SET autocommit=1'); |
There was a problem hiding this comment.
I wonder if I should be concerned with default settings for PHP and engine resources with approx 100, 000 inserts?
Perhaps safer to batch maybe every 10,000 or so!
|
That's it for this go around. Thanks SW for warning fix |
|
weno bueno :) |
bradymiller
reviewed
Feb 3, 2024
| } | ||
| fclose($records); | ||
| sqlStatementNoLog('COMMIT'); | ||
| sqlStatementNoLog('SET autocommit=1'); |
There was a problem hiding this comment.
Doesn't the following need to be placed above:
sqlStatementNoLog('SET autocommit=0');
sqlStatementNoLog('START TRANSACTION');
There was a problem hiding this comment.
Nice catch @bradymiller and thank you!
sjpadgett
added a commit
to sjpadgett/openemr
that referenced
this pull request
Feb 22, 2024
* Weno fixes and updates - Improve pharmacy import by using transactional queries. From 4 minutes to 40 seconds. - improve validation and error reporting. - some code cleanup for warnings and in general - fix frame screen output to use the current theme so user always see content. * - fix block style how nitpicking is this! * - fix all header blocks. * - no clue * php warning * styles * - I was running ci on wrong directory! tsktsk * - don't log thounsands of inserts --------- Co-authored-by: stephen waite <[email protected]> (cherry picked from commit e77ac66)
adunsulag
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #