This repository has been archived by the owner on May 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Fix #280: form field focus on input on component mount #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmespresso
changed the title
WIP: Form field focus on input on component mount
Form field focus on input on component mount
Dec 26, 2018
pmespresso
changed the title
Form field focus on input on component mount
Fix #280: form field focus on input on component mount
Dec 27, 2018
There's a prop called |
amaury1093
reviewed
Jan 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my PR #328, I think there's an easier way to achieve this.
Merge into yj-focus-formfield - Don't use keycodes
amaury1093
suggested changes
Jan 2, 2019
packages/fether-react/src/Accounts/CreateAccount/AccountName/AccountName.js
Outdated
Show resolved
Hide resolved
Tbaut
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works well!
Tested on JSON import and export.
amaury1093
approved these changes
Jan 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#280
fether-ui
to be a class component to focus on input on componentDidMount()