Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

EIP2929_journaling #79

Merged
merged 22 commits into from
Nov 4, 2020
Merged

EIP2929_journaling #79

merged 22 commits into from
Nov 4, 2020

Conversation

adria0
Copy link
Contributor

@adria0 adria0 commented Oct 23, 2020

No description provided.

@adria0 adria0 changed the base branch from main to dev October 27, 2020 07:17
@adria0 adria0 mentioned this pull request Oct 27, 2020
@adria0 adria0 marked this pull request as ready for review November 4, 2020 11:15
Copy link
Contributor

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Journaling allows us to rollback (revert) accessed addresses in current contract call if for some reason that contract fails to execute. Rollback is done when we enact_result. this LGTM

let mut params = ActionParams::default();
if spec.engine.params().eip2929_transition == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this if is okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that the 2929 is activated at first block, that is the usual way to say that something is activated from the beginning.

@adria0 adria0 merged commit 6078eea into dev Nov 4, 2020
@adria0 adria0 deleted the adria0/eip2929_4_yolo branch November 4, 2020 18:11
rakita pushed a commit that referenced this pull request Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants