Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update json tests #10400

Closed
wants to merge 3 commits into from
Closed

Update json tests #10400

wants to merge 3 commits into from

Conversation

cheme
Copy link
Contributor

@cheme cheme commented Feb 22, 2019

This is ongoing process (currently just moved the submodule reference).
cc @adilimroz

@cheme cheme added the A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. label Feb 22, 2019
@soc1c soc1c added this to the 2.5 milestone Feb 22, 2019
@soc1c soc1c added M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies. A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Feb 22, 2019
@soc1c
Copy link
Contributor

soc1c commented Feb 22, 2019

The reason we did not update them, is because the testing team didn't tag a release yet.

Can we figure out if there is any plan to tag a release upstream? (We recently decided to only use specific versions of the tests and not randomly update the develop branch)

@cheme
Copy link
Contributor Author

cheme commented Feb 22, 2019

Sure, we are only preparing the PR yet (there is still some missing/new test I think @adilimroz is looking into it).

@ordian
Copy link
Collaborator

ordian commented Jul 2, 2019

@cheme @adilimroz any updates on this?

@cheme
Copy link
Contributor Author

cheme commented Jul 4, 2019

I just checked, no new tag on eth tests repo.

@ordian ordian modified the milestones: 2.6, 2.7 Jul 12, 2019
@debris
Copy link
Collaborator

debris commented Jul 29, 2019

closing in favor of #10923 . Missing blockchain tests shall be also added to that pr

@debris debris closed this Jul 29, 2019
@denisgranha denisgranha deleted the ec-ethtestupdates branch March 17, 2020 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants