This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
fix(rpc): fix a bunch of clippy lints #10493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
reviewed
Mar 20, 2019
HCastano
reviewed
Mar 20, 2019
HCastano
reviewed
Mar 20, 2019
This commit fixes all uses of `redundant_field_names` and removes the ignored lint `redundant_field_names`
ordian
approved these changes
Mar 22, 2019
ordian
added
A8-looksgood 🦄
HCastano
reviewed
Mar 22, 2019
| @@ -135,7 +135,7 @@ impl<T: Default + Copy + Ord> StatsCalculator<T> { | |||
| #[derive(Default, Debug)] | |||
| pub struct RpcStats { | |||
| requests: RwLock<RateCalculator>, | |||
| roundtrips: RwLock<StatsCalculator<u32>>, | |||
| roundtrips: RwLock<StatsCalculator<u128>>, | |||
There was a problem hiding this comment.
What Clippy lint does this change correspond to?
There was a problem hiding this comment.
That's a good question it was this one https://rust-lang.github.io/rust-clippy/master/#duration_subsec
But I replaced our own as_micros() method with Duration::as_micros and don't truncate the result as u32
HCastano
approved these changes
Mar 22, 2019
ordian
added a commit
that referenced
this pull request
Apr 5, 2019
* master: (48 commits) ethcore: remove eth social and easthub chain configs (#10531) Initial support sccache for windows build (#10520) fix(light): make `OnDemand` generic instead of using the concrete type (#10514) private-tx: replace error_chain (#10510) Add trace information to eth_estimateGas (#10519) ethcore: add clique engine (#9981) verbose flag for cpp tests (#10524) Add a more realistic Batch test (#10511) docs: add changelogs for 2.3.{6,7,8} and 2.4.{1,2,3} (#10494) fix(rpc): fix a bunch of clippy lints (#10493) fix Sha3/keccak256 hash calculation for binaries (#10509) Add additional request tests (#10503) whisper/cli: add p2p port and ip parameters (#10057) fix(time-utils): add missing license (#10497) fix(extract `timestamp_checked_add` as lib) (#10383) fix(rpc): lint `unused_extern_crates` + fix warns (#10489) fix win&mac build (#10486) Сaching through docker volume (#10477) OpenBlock::new take IntoIterator instead of mutable ref to Iterator (#10480) simplify block module and usage (#10479) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to cleanup the
rpccrate after #10217 was merged which has a lot of needlessinto()I have ignored a bunch of lints which I think is just annoying which can be found in
rpc/lib.rs. I can revert that change if anyone doesn't agree.Furthermore, I have fixed most
clippy::alllints with ~15 exceptions!