Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Treat blocks, that already downloaded, as synced #10864

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3c85f29
version: betalize 2.5
soc1c Apr 2, 2019
b52ac20
beta backports (#10576)
soc1c Apr 8, 2019
e0141f8
beta 2.5.1 (#10643)
soc1c May 10, 2019
c2487cf
ci: publish docs debug (#10638) (#10660)
soc1c May 14, 2019
adabd81
beta ci: backport missing diff from master (#10661)
soc1c May 14, 2019
ecbafb2
backports for beta 2.5.2 (#10737)
soc1c Jun 11, 2019
3fd58bd
Beta 2.5.3 (#10776)
s3krit Jun 25, 2019
d60e638
Beta 2.5.4 (#10827)
s3krit Jul 1, 2019
3ebc769
version: stabilise v2.5 (#10857)
s3krit Jul 8, 2019
ff398fe
V2.5.6 stable (#10961)
s3krit Aug 12, 2019
6bd7db9
v2.5.7 stable (#11006)
s3krit Aug 29, 2019
45f27ce
v2.5.8-stable (#11041)
s3krit Sep 12, 2019
24a4fdf
Don't build rpc with ethcore test-helpers (#11048)
dvdplm Sep 13, 2019
7c7b181
v2.5.8-stable (rev2) (#11051)
s3krit Sep 13, 2019
c52a6c8
update CHANGELOG.md (#11057)
s3krit Sep 16, 2019
b2277f6
v2.5.9-stable (#11089)
s3krit Sep 26, 2019
06c7096
Update CHANGELOG.md and version (#11093)
s3krit Sep 26, 2019
64c7156
Treat blocks that already downloaded as imported
grbIzl Jul 8, 2019
e7b8d0e
Treat only blocks in queue as synced
grbIzl Jul 9, 2019
80b6d04
Additional logging, REVERT BEFORE MERGE
grbIzl Oct 29, 2019
841d40d
More logs. REVERT BEFORE MERGE
grbIzl Oct 30, 2019
34cbe85
Log message fixed. REVERT BEFORE MERGE
grbIzl Oct 30, 2019
4a94d63
More logging. REVERT BEFORE MERGE
grbIzl Oct 30, 2019
3a10c18
Move log traces into the proper place. REVERT BEFORE MERGE
grbIzl Oct 30, 2019
4d22dc1
Trace panic message. REVERT BEFORE MERGE
grbIzl Oct 30, 2019
5263c1d
Revert all additional logging made
grbIzl Oct 31, 2019
109473b
Fix after rebase
grbIzl Nov 5, 2019
e20cf2a
CI to build on not protected branch
TriplEight Nov 6, 2019
9157919
Enable linux build
grbIzl Nov 6, 2019
4a6f17a
Disable benches for the branch
grbIzl Nov 6, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,42 @@ Also, try to include **steps to reproduce** the issue and expand on the **actual

If you would like to contribute to Parity Ethereum, please **fork it**, fix bugs or implement features, and [propose a pull request](https://github.com/paritytech/parity-ethereum/compare).

Please, refer to the [Coding Guide](https://wiki.parity.io/Coding-guide) in our wiki for more details about hacking on Parity.
### Labels & Milestones

We use [labels](https://github.com/paritytech/parity-ethereum/labels) to manage PRs and issues and communicate the state of a PR. Please familiarize yourself with them. Furthermore we are organizing issues in [milestones](https://github.com/paritytech/parity-ethereum/milestones). Best way to get started is to a pick a ticket from the current milestone tagged [`easy`](https://github.com/paritytech/parity-ethereum/labels/Q2-easy%20%F0%9F%92%83) and get going, or [`mentor`](https://github.com/paritytech/parity-ethereum/labels/Q1-mentor%20%F0%9F%95%BA) and get in contact with the mentor offering their support on that larger task.

### Rules

There are a few basic ground-rules for contributors (including the maintainer(s) of the project):

* **No pushing directly to the master branch**.
* **All modifications** must be made in a **pull-request** to solicit feedback from other contributors.
* Pull-requests cannot be merged before CI runs green and two reviewers have given their approval.
* Contributors should adhere to the [Parity Ethereum Style Guide](https://wiki.parity.io/Parity-Ethereum-Style-Guide).

### Recommendations

* **Non-master branch names** *should* be prefixed with a short name moniker, followed by the associated Github Issue ID (if any), and a brief description of the task using the format `<GITHUB_USERNAME>-<ISSUE_ID>-<BRIEF_DESCRIPTION>` (e.g. `gavin-123-readme`). The name moniker helps people to inquiry about their unfinished work, and the GitHub Issue ID helps your future self and other developers (particularly those who are onboarding) find out about and understand the original scope of the task, and where it fits into Parity Ethereum [Projects](https://github.com/paritytech/parity-ethereum/projects).
* **Remove stale branches periodically**

### Preparing Pull Requests

* If your PR does not alter any logic (e.g. comments, dependencies, docs), then it may be tagged [`insubstantial`](https://github.com/paritytech/parity-ethereum/pulls?q=is%3Aopen+is%3Apr+label%3A%22A2-insubstantial+%F0%9F%91%B6%22).

* Once a PR is ready for review please add the [`pleasereview`](https://github.com/paritytech/parity-ethereum/pulls?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+label%3A%22A0-pleasereview+%F0%9F%A4%93%22+) label.

### Reviewing Pull Requests*:

* At least two reviewers are required to review PRs (even for PRs tagged [`insubstantial`](https://github.com/paritytech/parity-ethereum/pulls?q=is%3Aopen+is%3Apr+label%3A%22A2-insubstantial+%F0%9F%91%B6%22)).

When doing a review, make sure to look for any:

* Buggy behavior.
* Undue maintenance burden.
* Breaking with house coding style.
* Pessimization (i.e. reduction of speed as measured in the projects benchmarks).
* Breaking changes should be carefuly reviewed and tagged as such so they end up in the [changelog](../CHANGELOG.md).
* Uselessness (i.e. it does not strictly add a feature or fix a known issue).

## License.

Expand Down
Loading