This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Better error message for rpc gas price errors #10931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @seunlanlege signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ordian
reviewed
Aug 1, 2019
ordian
added
B0-patch-stable 🕷
ordian
approved these changes
Aug 1, 2019
ordian
added
the
A6-mustntgrumble 💦
Codecov Report
@@ Coverage Diff @@
## master #10931 +/- ##
=========================================
Coverage ? 5.2%
=========================================
Files ? 659
Lines ? 94849
Branches ? 19472
=========================================
Hits ? 4936
Misses ? 87884
Partials ? 2029Continue to review full report at Codecov.
|
dvdplm
suggested changes
Aug 6, 2019
| @@ -42,6 +42,14 @@ pub enum Error { | |||
| /// Transaction gas price | |||
| got: U256, | |||
| }, | |||
| /// Transaction has too low fee | |||
| /// (there is already a transaction with the same sender-nonce but higher gas price) | |||
There was a problem hiding this comment.
We need to document this better: what is the difference between TooCheapToReplace and TxTooCheapToReplace – it is not clear to when we return the one or the other.
dvdplm
approved these changes
Aug 8, 2019
|
test failures seem legit |
ordian
reviewed
Aug 8, 2019
seunlanlege
force-pushed
the
rpc-txpool-error
branch
from
1e77569
to
54181d8
Compare
ordian
added
A8-looksgood 🦄
* master: [evmbin] fix compilation (#10976) Update to latest trie version. (#10972) [blooms-db] Fix benchmarks (#10974) Fix ethcore/benches build. (#10964) tx-pool: accept local tx with higher gas price when pool full (#10901) Disable unsyncable expanse chain (#10926) Extract Machine from ethcore (#10949) removed redundant state_root function from spec, improve spec error types (#10955) Add support for Energy Web Foundation's new chains (#10957) [evmbin] add more tests to main.rs (#10956) Fix compiler warnings in util/io and upgrade to edition 2018 Upgrade mio to latest (#10953) unify loading spec && further spec cleanups (#10948) refactor: Refactor evmbin CLI (#10742) journaldb changes (#10929) Allow default block parameter to be blockHash (#10932) Enable sealing when engine is ready (#10938) Fix some warnings and typos. (#10941) Updated [email protected] key (#10939) Change the return type of step_inner function. (#10940)
dvdplm
added a commit
that referenced
this pull request
Aug 15, 2019
* master: Extract the Engine trait (#10958) Better error message for rpc gas price errors (#10931) [.gitlab.yml] cargo check ethcore benches (#10965) Verify transaction against its block during import (#10954) [evmbin] fix compilation (#10976) Update to latest trie version. (#10972) [blooms-db] Fix benchmarks (#10974) Fix ethcore/benches build. (#10964) tx-pool: accept local tx with higher gas price when pool full (#10901) Disable unsyncable expanse chain (#10926)
s3krit
pushed a commit
that referenced
this pull request
Sep 11, 2019
* Better error message for rpc gas price errors * correct tests * dedupe error variants * fixed tests, removed spacing
s3krit
pushed a commit
that referenced
this pull request
Sep 11, 2019
* Better error message for rpc gas price errors * correct tests * dedupe error variants * fixed tests, removed spacing
s3krit
added a commit
that referenced
this pull request
Sep 12, 2019
* add more tx tests (#11038) * Fix parallel transactions race-condition (#10995) * Add blake2_f precompile (#11017) * [trace] introduce trace failed to Ext (#11019) * Edit publish-onchain.sh to use https (#11016) * Fix deadlock in network-devp2p (#11013) * EIP 1108: Reduce alt_bn128 precompile gas costs (#11008) * xDai chain support and nodes list update (#10989) * EIP 2028: transaction gas lowered from 68 to 16 (#10987) * EIP-1344 Add CHAINID op-code (#10983) * manual publish jobs for releases, no changes for nightlies (#10977) * [blooms-db] Fix benchmarks (#10974) * Verify transaction against its block during import (#10954) * Better error message for rpc gas price errors (#10931) * Fix fork choice (#10837) * Fix compilation on recent nightlies (#10991)
s3krit
added a commit
that referenced
this pull request
Sep 12, 2019
* add more tx tests (#11038) * Fix parallel transactions race-condition (#10995) * Add blake2_f precompile (#11017) * [trace] introduce trace failed to Ext (#11019) * Edit publish-onchain.sh to use https (#11016) * Fix deadlock in network-devp2p (#11013) * EIP 1108: Reduce alt_bn128 precompile gas costs (#11008) * xDai chain support and nodes list update (#10989) * EIP 2028: transaction gas lowered from 68 to 16 (#10987) * EIP-1344 Add CHAINID op-code (#10983) * manual publish jobs for releases, no changes for nightlies (#10977) * [blooms-db] Fix benchmarks (#10974) * Verify transaction against its block during import (#10954) * Better error message for rpc gas price errors (#10931) * tx-pool: accept local tx with higher gas price when pool full (#10901) * Fix fork choice (#10837) * Cleanup unused vm dependencies (#10787) * Fix compilation on recent nightlies (#10991)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you were trying to replace a transaction in the transaction pool, (i.e same nonce) but you don't supply a higher gas price; you get this error telling you that your "transaction's gas price does satisfy node's minimal gas price"
This error message has been changed to:
closes #10348