Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Switching to stable-track #11377

Merged
merged 26 commits into from
Jan 22, 2020
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ae5d138
sccache "stop server" - > "show stats"
General-Beck Jan 10, 2020
81d048a
remove testing and beta from update, cli, etc.
General-Beck Jan 10, 2020
d93a21a
Beta->Nigthly updater
General-Beck Jan 10, 2020
eccd90c
Beta->Nightly
TriplEight Jan 10, 2020
7e127c6
->Nightly and fix
TriplEight Jan 10, 2020
b648d85
updater ->Stable
TriplEight Jan 10, 2020
7d922c9
Testing->Nightly
TriplEight Jan 10, 2020
b18624f
Update scripts/gitlab/test-linux.sh
s3krit Jan 13, 2020
cbda26d
sccache "stop server" - > "show stats"
General-Beck Jan 10, 2020
11490ff
remove testing and beta from update, cli, etc.
General-Beck Jan 10, 2020
e6600c9
Beta->Nigthly updater
General-Beck Jan 10, 2020
215bcc5
Beta->Nightly
TriplEight Jan 10, 2020
7b17d34
->Nightly and fix
TriplEight Jan 10, 2020
dc62eec
updater ->Stable
TriplEight Jan 10, 2020
7050983
Testing->Nightly
TriplEight Jan 10, 2020
33f7bc8
Update scripts/gitlab/test-linux.sh
s3krit Jan 13, 2020
69a0c61
Update CHANGELOGs and version
s3krit Jan 15, 2020
45c72f6
temporarily allow darwin and windows to be built on any branch
s3krit Jan 16, 2020
d16abc4
Merge branch 'stable-track' of github.com:paritytech/parity-ethereum …
s3krit Jan 17, 2020
98d5d12
fix check-benches job
s3krit Jan 20, 2020
e2d11a1
Revert "temporarily allow darwin and windows to be built on any branch"
s3krit Jan 20, 2020
ef31e20
fix check-benches job
s3krit Jan 20, 2020
01c29f7
Merge branch 'master' into stable-track
s3krit Jan 20, 2020
c154040
Revert changing track from `nightly` to `stable`
s3krit Jan 20, 2020
bc524b6
fix test: rpc_parity_upgrade_ready
s3krit Jan 20, 2020
71f3709
fix tests: rpc_parity_version_info, rpc_parity_releases_info
s3krit Jan 20, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitlab-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ variables:
.releaseable_branches: # list of git refs for building GitLab artifacts (think "pre-release binaries")
only: &releaseable_branches
- stable
- beta
- tags
- schedules

Expand Down Expand Up @@ -308,7 +307,7 @@ publish-release-awss3-nightly: &publish-release-awss3
script:
- echo "__________Push binaries to AWS S3____________"
- case "${SCHEDULE_TAG:-${CI_COMMIT_REF_NAME}}" in
(beta|stable|nightly)
(stable|nightly)
export BUCKET=releases.parity.io/ethereum;
;;
(*)
Expand Down
2 changes: 1 addition & 1 deletion parity/cli/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ usage! {

ARG arg_release_track: (String) = "current", or |c: &Config| c.parity.as_ref()?.release_track.clone(),
"--release-track=[TRACK]",
"Set which release track we should use for updates. TRACK can be one of: stable - Stable releases; beta - Beta releases; nightly - Nightly releases (unstable); testing - Testing releases (do not use); current - Whatever track this executable was released on.",
"Set which release track we should use for updates. TRACK can be one of: stable - Stable releases; nightly - Nightly releases (unstable); testing - Testing releases (do not use); current - Whatever track this executable was released on.",
TriplEight marked this conversation as resolved.
Show resolved Hide resolved

ARG arg_chain: (String) = "foundation", or |c: &Config| c.parity.as_ref()?.chain.clone(),
"--chain=[CHAIN]",
Expand Down
8 changes: 2 additions & 6 deletions parity/configuration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -981,9 +981,7 @@ impl Configuration {
},
track: match self.args.arg_release_track.as_ref() {
"stable" => ReleaseTrack::Stable,
"beta" => ReleaseTrack::Beta,
"nightly" => ReleaseTrack::Nightly,
"testing" => ReleaseTrack::Testing,
"current" => ReleaseTrack::Unknown,
_ => return Err("Invalid value for `--releases-track`. See `--help` for more information.".into()),
},
Expand Down Expand Up @@ -1512,10 +1510,8 @@ mod tests {
#[test]
fn should_parse_updater_options() {
// when
let conf0 = parse(&["parity", "--release-track=testing"]);
let conf1 = parse(&["parity", "--auto-update", "all", "--no-consensus", "--auto-update-delay", "300"]);
let conf2 = parse(&["parity", "--no-download", "--auto-update=all", "--release-track=beta", "--auto-update-delay=300", "--auto-update-check-frequency=100"]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're removing these, we also need to remove the asserts just below in this file. This is leading to tests being broken: https://gitlab.parity.io/parity/parity-ethereum/-/jobs/356325

let conf3 = parse(&["parity", "--auto-update=xxx"]);
let conf0 = parse(&["parity", "--auto-update", "all", "--no-consensus", "--auto-update-delay", "300"]);
let conf1 = parse(&["parity", "--auto-update=xxx"]);

// then
assert_eq!(conf0.update_policy().unwrap(), UpdatePolicy {
Expand Down
16 changes: 2 additions & 14 deletions scripts/docker/hub/publish-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -23,19 +23,6 @@ case "${SCHEDULE_TAG:-${CI_COMMIT_REF_NAME}}" in
--tag "parity/parity:${SCHEDULE_TAG}" \
--file tools/Dockerfile .;
docker push "parity/parity:${SCHEDULE_TAG}";;
"beta")
echo "Docker TAGs - 'parity/parity:beta', 'parity/parity:latest', \
'parity/parity:${VERSION}-${CI_COMMIT_REF_NAME}'";
docker build --no-cache \
--build-arg VCS_REF="${CI_COMMIT_SHA}" \
--build-arg BUILD_DATE="$(date -u '+%Y-%m-%dT%H:%M:%SZ')" \
--tag "parity/parity:beta" \
--tag "parity/parity:latest" \
--tag "parity/parity:${VERSION}-${CI_COMMIT_REF_NAME}" \
--file tools/Dockerfile .;
docker push "parity/parity:beta";
docker push "parity/parity:latest";
docker push "parity/parity:${VERSION}-${CI_COMMIT_REF_NAME}";;
"stable")
echo "Docker TAGs - 'parity/parity:${VERSION}-${CI_COMMIT_REF_NAME}', 'parity/parity:stable'";
docker build --no-cache \
Expand All @@ -45,7 +32,8 @@ case "${SCHEDULE_TAG:-${CI_COMMIT_REF_NAME}}" in
--tag "parity/parity:stable" \
--file tools/Dockerfile .;
docker push "parity/parity:${VERSION}-${CI_COMMIT_REF_NAME}";
docker push "parity/parity:stable";;
docker push "parity/parity:stable";
docker push "parity/parity:latest";;
dvdplm marked this conversation as resolved.
Show resolved Hide resolved
v[0-9]*.[0-9]*)
echo "Docker TAG - 'parity/parity:${VERSION}-${TRACK}'"
docker build --no-cache \
Expand Down
1 change: 0 additions & 1 deletion scripts/gitlab/publish-snap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ SNAP_PACKAGE="parity_"$VERSION"_"$BUILD_ARCH".snap"
# Choose snap release channel based on parity ethereum version track
case ${TRACK} in
nightly) export GRADE="devel" CHANNEL="edge";;
beta) export GRADE="stable" CHANNEL="beta";;
stable) export GRADE="stable" CHANNEL="stable";;
*) echo "No release" && exit 0;;
esac
Expand Down
2 changes: 1 addition & 1 deletion scripts/gitlab/rust-changes.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ echo "__________Checking if Rust files were changed__________"
git log --graph --oneline --decorate=short -n 10

case ${SCHEDULE_TAG:-${CI_COMMIT_REF_NAME}} in
(beta|stable)
(stable)
export GIT_COMPARE=origin/${SCHEDULE_TAG:-${CI_COMMIT_REF_NAME}}~
;;
(master|nightly)
Expand Down
26 changes: 4 additions & 22 deletions updater/src/types/release_track.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,8 @@ use std::fmt;
pub enum ReleaseTrack {
/// Stable track.
Stable = 1,
/// Beta track.
Beta = 2,
/// Nightly track.
Nightly = 3,
/// Testing track.
Testing = 4,
Nightly = 2,
/// No known track, also "current executable's track" when it's not yet known.
Unknown = 0,
}
Expand All @@ -38,9 +34,7 @@ impl fmt::Display for ReleaseTrack {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "{}", match *self {
ReleaseTrack::Stable => "stable",
ReleaseTrack::Beta => "beta",
ReleaseTrack::Nightly => "nightly",
ReleaseTrack::Testing => "testing",
ReleaseTrack::Unknown => "unknown",
})
}
Expand All @@ -50,9 +44,7 @@ impl<'a> From<&'a str> for ReleaseTrack {
fn from(s: &'a str) -> Self {
match s {
"stable" => ReleaseTrack::Stable,
"beta" => ReleaseTrack::Beta,
"nightly" => ReleaseTrack::Nightly,
"testing" => ReleaseTrack::Testing,
_ => ReleaseTrack::Unknown,
}
}
Expand All @@ -62,9 +54,7 @@ impl From<u8> for ReleaseTrack {
fn from(i: u8) -> Self {
match i {
1 => ReleaseTrack::Stable,
2 => ReleaseTrack::Beta,
3 => ReleaseTrack::Nightly,
4 => ReleaseTrack::Testing,
2 => ReleaseTrack::Nightly,
_ => ReleaseTrack::Unknown,
}
}
Expand All @@ -83,36 +73,28 @@ mod tests {
#[test]
fn test_release_track_from() {
assert_eq!(ReleaseTrack::Stable, 1u8.into());
assert_eq!(ReleaseTrack::Beta, 2u8.into());
assert_eq!(ReleaseTrack::Nightly, 3u8.into());
assert_eq!(ReleaseTrack::Testing, 4u8.into());
assert_eq!(ReleaseTrack::Nightly, 2u8.into());
assert_eq!(ReleaseTrack::Unknown, 0u8.into());
}

#[test]
fn test_release_track_into() {
assert_eq!(1u8, u8::from(ReleaseTrack::Stable));
assert_eq!(2u8, u8::from(ReleaseTrack::Beta));
assert_eq!(3u8, u8::from(ReleaseTrack::Nightly));
assert_eq!(4u8, u8::from(ReleaseTrack::Testing));
assert_eq!(2u8, u8::from(ReleaseTrack::Nightly));
assert_eq!(0u8, u8::from(ReleaseTrack::Unknown));
}

#[test]
fn test_release_track_from_str() {
assert_eq!(ReleaseTrack::Stable, "stable".into());
assert_eq!(ReleaseTrack::Beta, "beta".into());
assert_eq!(ReleaseTrack::Nightly, "nightly".into());
assert_eq!(ReleaseTrack::Testing, "testing".into());
assert_eq!(ReleaseTrack::Unknown, "unknown".into());
}

#[test]
fn test_release_track_into_str() {
assert_eq!("stable", ReleaseTrack::Stable.to_string());
assert_eq!("beta", ReleaseTrack::Beta.to_string());
assert_eq!("nightly", ReleaseTrack::Nightly.to_string());
assert_eq!("testing", ReleaseTrack::Testing.to_string());
assert_eq!("unknown", ReleaseTrack::Unknown.to_string());
}
}
2 changes: 1 addition & 1 deletion util/version/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ mod generated {

#[cfg(feature = "final")]
const THIS_TRACK: &'static str = generated::TRACK;
// ^^^ should be reset in Cargo.toml to "stable" or "beta" according to the release branch.
// ^^^ should be reset in Cargo.toml to "stable" according to the release branch.

#[cfg(not(feature = "final"))]
const THIS_TRACK: &'static str = "unstable";
Expand Down