-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
It looks like @ethcoreorg hasn't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io Once you've signed, please reply to this thread with Many thanks, Parity Technologies CLA Bot |
[clabot:check] |
It looks like @ethcoreorg signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
7fd7621
to
6a3713d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you please submit a different PR for updating ProgPoW to 0.93 so that it's easier to review and backport (please also mention
We use ProgPoW 0.9.3 version as suggested on Specification https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1057.md#specification - 0.9.2 version is considered as deprecated since it wouldn't benefit mining with AMD card
in the module docs)? Other than that, looks good to me.
7755786
to
af151a1
Compare
4c1e213
to
5ae66ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use explicit activate_at 0
for all builtins for verbosity/readability and this should be ready to be merged.
5ae66ea
to
cb2f38c
Compare
* support ethercore mainnet with basic token metrics and ProgPoW support, ecip1017, bomb defuse & istanbul
cb2f38c
to
f3f0759
Compare
@niklasad1 Addressed comments! |
Builtin now match with foundation and ropsten specs https://github.com/paritytech/parity-ethereum/blob/master/ethcore/res/ethereum/ropsten.json#L3328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, thank you
Even though I prefer to have explicit activation if it missing it will be assigned to 0
* support ethercore mainnet with basic token metrics and ProgPoW support, ecip1017, bomb defuse & istanbul
…pstream * master: Add POSDAO transition and malice report queue. (#11245) update master/nightly version: v2.8.0 (#11419) ethcore/res: remove morden testnet (#11392) fix: export hardcoded sync format (#11416) update hardcoded headers: mainnet and ropsten (#11414) AuthorityEngine: Minor cleanups. (#11408) Update POA bootnodes (#11411) Add EtherCore support (#11402) verification: fix race same block + misc (#11400) Update ProgPoW to 0.9.3 (#11407) update classic testnet bootnodes (#11398) dependencies: bump `derive_more v0.99` (#11405) engine error: remove faulty/unused `From` (#11404) Switching to stable-track (#11377) ethcore/res: fix ethereum classic chainspec blake2_f activation block num (#11391) Update copyright notice 2020 (#11386)
Description
Support EtherCore Mainnet, Proof of Work Ethereum compatible network.
Homepage: https://ethercore.org
Block Explorer: https://explorer.ethercore.org
RPC Endpoint: https://rpc.ethercore.org
ChainId / SLIP-44: 466 satoshilabs/slips#847
Official Email: [email protected]
ps) We use ProgPoW 0.9.3 version as suggested on Specification https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1057.md#specification - 0.9.2 version is considered as deprecated since it wouldn't benefit mining with AMD cards.