Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[eth classic chainspec]: remove balance = 1 in builtin blake2_f #11459

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

niklasad1
Copy link
Collaborator

@niklasad1 niklasad1 commented Feb 6, 2020

Closes #11431

This removes balance = 1 in the builtin blake2_f which doesn't change the genesis_hash

@niklasad1 niklasad1 requested a review from dvdplm February 6, 2020 00:44
@niklasad1 niklasad1 added A0-pleasereview 🤓 Pull request needs code review. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch. labels Feb 6, 2020
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem.

@dvdplm
Copy link
Collaborator

dvdplm commented Feb 6, 2020

@niklasad1 it would be good to document this somewhere, it's a easy to make this mistake.

@niklasad1 niklasad1 changed the title [eth classic chainspec]: disable blake2_f [eth classic chainspec]: remove balance = 1 in builtin blake2_f Feb 6, 2020
@ordian ordian merged commit 06138ec into master Feb 6, 2020
@ordian ordian deleted the na-forward-11458 branch February 6, 2020 10:12
dvdplm added a commit that referenced this pull request Feb 8, 2020
…pstream

* master:
  upgrade some of the dependencies (#11467)
  Some more release track changes to README.md (#11465)
  Update simple one-line installer due to switching to a single stable release track (#11463)
  update Dockerfile (#11461)
  Implement EIP-2124 (#11456)
  [eth classic chainspec]: remove `balance = 1` (#11459)
  just to make sure we don't screw up this again (#11455)
  backwards compatible call_type creation_method (#11450)
  gcc to clang (#11453)
  Avoid copies (#11451)
  Cargo.lock: cargo lock translate (#11448)
dvdplm added a commit that referenced this pull request Feb 10, 2020
* master:
  [eth classic chainspec]: remove `balance = 1` (#11459)
  just to make sure we don't screw up this again (#11455)
  backwards compatible call_type creation_method (#11450)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-pleasereview 🤓 Pull request needs code review. B0-patch-stable 🕷 Pull request should also be back-ported to the stable branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classic: no syncing on 2.7.1
3 participants