-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
# Conflicts: # js/src/modals/DappPermissions/dappPermissions.js # js/src/ui/SelectionList/selectionList.js
Really like the new layout ! Some small issues though:
One thing that would be great (even though could be outside of this PR), is to use the same upload component that for the Import in Accounts (click or drop). I think it would look especially great in the Portal. |
/> | ||
} | ||
onChange={ this.onEditAddress } | ||
ref='inputAddress' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there some ref
s here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, didn't remove that one - it was a toy in dev. Will remove, unused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope thinking of another one. No idea, not used there or in the tests, so unsure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So can we remove them ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have been. (Unless I didn't push?)
Yeap, didn't push- pushing now.
Import fix, thanks @ngotchac - https://github.com/ethcore/parity/pull/4674 (Logged https://github.com/ethcore/parity/issues/4675 - would be good to convert file uploads consistently to dropzones) |
Ongoing effort to enhance dialogs with better layouts. (Raised in https://github.com/ethcore/parity/pull/4625). This does not cover all the modals and does not address every thing on each modal - it is part of an ongoing process. (Currently trying to go wide with first-touch before going deep.)
Includes & depends on (these to be merged first, relevant parts in here) -
~/ui/SelectionList
component https://github.com/ethcore/parity/pull/4639Geth account import fix https://github.com/ethcore/parity/pull/4641CreateAccount/Type Selection -
CreateAccount/Geth import -
CreateAccount/Done -
AddAddress -