This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Spec with tested Morden genesis decoder and builtins. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,7 +9,7 @@ authors = ["Ethcore <[email protected]>"] | |||
| [dependencies] | |||
| log = "0.3" | |||
| env_logger = "0.3" | |||
| ethcore-util = "0.1.0" | |||
| ethcore-util = { path = "../ethcore-util" } | |||
There was a problem hiding this comment.
we shouldn't hardcode paths. It's better to use .cargo/config and overwrite paths only locally.
eg.
> ls -a
.cargo ethcore ethcore-client ethcore-util
> cat .cargo/config
paths = ["/Users/marek/projects/ethcore/ethcore-util", "/Users/marek/projects/ethcore/ethcore"]
There was a problem hiding this comment.
For some reason that causes a trip to crates.io and recompilation on each cargo build. A considerable slowdown
|
Looks OK to me. I can implement the rest of the built-ins after this is merged |
gavofyork
changed the title
gavofyork
pushed a commit
that referenced
this pull request
Jan 8, 2016
Spec with tested Morden genesis decoder and builtins.
gavofyork
pushed a commit
that referenced
this pull request
Jan 17, 2016
Make clear when the panic occurs to a missing trie root.
niklasad1
pushed a commit
to niklasad1/parity
that referenced
this pull request
Mar 12, 2019
Add consensus tests + some fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.