Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

rpc(debug_getBadBlocks): fix test #9502

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

ordian
Copy link
Collaborator

@ordian ordian commented Sep 8, 2018

Hash is printed with {:#x}, which implies 0x prefix.
Not sure why CI passed before, but it fails now.

@ordian ordian added the A0-pleasereview 🤓 Pull request needs code review. label Sep 8, 2018
@ordian ordian requested a review from tomusdrw September 8, 2018 14:08
@parity-cla-bot
Copy link

It looks like @ordian signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@5chdn 5chdn added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Sep 8, 2018
@5chdn 5chdn added this to the 2.1 milestone Sep 8, 2018
@5chdn 5chdn merged commit 4040d73 into openethereum:master Sep 8, 2018
@5chdn 5chdn removed the A0-pleasereview 🤓 Pull request needs code review. label Sep 8, 2018
@ordian ordian deleted the fix-bad-blocks-test branch September 8, 2018 15:35
priom pushed a commit to goerli/parity-goerli that referenced this pull request Sep 8, 2018
* parity: print correct keys path on startup

* rpc(debug_getBadBlocks): fix test (openethereum#9502)
priom pushed a commit to goerli/parity-goerli that referenced this pull request Sep 8, 2018
* ethcore: add goerli chainspec

* ethcore: allow using goerli chain spec

* cli: add goerli to cli description

* parity: add goerli chain to params

* rpc(debug_getBadBlocks): fix test (openethereum#9502)
ChainSafeSystems pushed a commit to goerli/parity-goerli that referenced this pull request Sep 9, 2018
* rpc(debug_getBadBlocks): fix test (openethereum#9502)

* Generalized blockReward and difficultyBombDelays config (openethereum#9480)

* Implement multi blockReward

* Implement difficultyBombDelays

* Fix json crate compile

* json keys can only be string

* parity: print correct keys path on startup (openethereum#9501)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants