Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

bump smallvec to 0.6 in ethcore-light, ethstore and whisper #9588

Merged
merged 5 commits into from
Sep 25, 2018
Merged

bump smallvec to 0.6 in ethcore-light, ethstore and whisper #9588

merged 5 commits into from
Sep 25, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Sep 18, 2018

part of #9558

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Sep 18, 2018
niklasad1
niklasad1 approved these changes Sep 18, 2018
View reviewed changes
Copy link
Collaborator

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but can you explain why you removed smallvec in ethcore-sync?

@ordian
Copy link
Collaborator

ordian commented Sep 18, 2018

Now, that paritytech/parity-common/pull/63 is merged, could you publish transaction-pool (and tag the repo) and bump it here? The remaining outdated smallvec dep is from hyper.

@5chdn 5chdn added this to the 2.2 milestone Sep 19, 2018
@debris
Copy link
Collaborator Author

debris commented Sep 19, 2018

Looks good to me but can you explain why you removed smallvec in ethcore-sync?

@niklasad1 , because only SmallVec<[H256; 1]>; was used. I doubt that it has any performance benefits for receipts list.

@debris
Copy link
Collaborator Author

debris commented Sep 19, 2018

could you publish transaction-pool (and tag the repo) and bump it here?

Published and bumped

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Sep 19, 2018
@debris
Copy link
Collaborator Author

debris commented Sep 19, 2018 •
edited
Loading

@tomusdrw can you take a look at this? I suspect that the failure is caused by some changes in transaction-pool that are unrelated to smallvec version bump

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodtestsfail 🤖 Pull request is reviewed well, but cannot be merged due to tests failing. labels Sep 24, 2018
@5chdn 5chdn merged commit 2609e2d into master Sep 25, 2018
@5chdn 5chdn deleted the bump-smallvec branch September 25, 2018 10:25
dvdplm added a commit that referenced this pull request Sep 27, 2018
@dvdplm
Merge remote-tracking branch 'origin/master' into dp/chore/update-com…
d86ba16 
…mon-deps

* origin/master:
  ethereum libfuzzer integration small change (#9547)
  cli: remove reference to --no-ui in --unlock flag help (#9616)
  remove master from releasable branches (#9655)
  ethcore/VerificationQueue don't spawn up extra `worker-threads` when explictly specified not to (#9620)
  RPC: parity_getBlockReceipts (#9527)
  Remove unused dependencies (#9589)
  ignore key_server_cluster randomly failing tests (#9639)
  ethcore: handle vm exception when estimating gas (#9615)
  fix bad-block reporting no reason (#9638)
  Use static call and apparent value transfer for block reward contract code (#9603)
  HF in POA Sokol (2018-09-19) (#9607)
  bump smallvec to 0.6 in ethcore-light, ethstore and whisper (#9588)
  Add constantinople conf to EvmTestClient. (#9570)
5chdn pushed a commit that referenced this pull request Nov 27, 2018
@debris @5chdn
bump smallvec to 0.6 in ethcore-light, ethstore and whisper (#9588)
bcd6757 
* bump smallvec to 0.6 in ethcore-light, ethstore and whisper

* bump transaction-pool

* Fix test.
@5chdn 5chdn mentioned this pull request Nov 27, 2018
Merged
10 tasks
5chdn added a commit that referenced this pull request Nov 28, 2018
@5chdn
Backports for stable 2.1.7 (#9975)
126208c 
* version: bump stable to 2.1.7

* Adjust requests costs for light client (#9925)

* PIP Table Cost relative to average peers instead of max peers

* Add tracing in PIP new_cost_table

* Update stat peer_count

* Use number of leeching peers for Light serve costs

* Fix test::light_params_load_share_depends_on_max_peers (wrong type)

* Remove (now) useless test

* Remove `load_share` from LightParams.Config
Prevent div. by 0

* Add LEECHER_COUNT_FACTOR

* PR Grumble: u64 to u32 for f64 casting

* Prevent u32 overflow for avg_peer_count

* Add tests for LightSync::Statistics

* Fix empty steps (#9939)

* Don't send empty step twice or empty step then block.

* Perform basic validation of locally sealed blocks.

* Don't include empty step twice.

* prevent silent errors in daemon mode, closes #9367 (#9946)

* Fix light client informant while syncing (#9932)

* Add `is_idle` to LightSync to check importing status

* Use SyncStateWrapper to make sure is_idle gets updates

* Update is_major_import to use verified queue size as well

* Add comment for `is_idle`

* Add Debug to `SyncStateWrapper`

* `fn get` -> `fn into_inner`

*  ci: rearrange pipeline by logic (#9970)

* ci: rearrange pipeline by logic

* ci: rename docs script

* Add readiness check for docker container (#9804)

* Update Dockerfile

Since parity is built for "mission critical use", I thought other operators may see the need for this.

Adding the `curl` and `jq` commands allows for an extremely simple health check to be usable in container orchestrators.

For example. Here is a health check for a parity docker container running in Kubernetes.

This can be setup as a readiness Probe that would prevent clustered nodes that aren't ready from serving traffic.

```bash
#!/bin/bash

ETH_SYNCING=$(curl -X POST --data '{"jsonrpc":"2.0","method":"eth_syncing","params":[],"id":1}' http://localhost:8545 -H 'Content-Type: application/json')
RESULT=$(echo "$ETH_SYNCING | jq -r .result)

if [ "$RESULT" == "false" ]; then
  echo "Parity is ready to start accepting traffic"
  exit 0
else
  echo "Parity is still syncing the blockchain"
  exit 1
fi
```

* add sync check script

* Fix docker script (#9854)


* Dockerfile: change source path of the newly added check_sync.sh (#9869)

* Do not use the home directory as the working dir in docker (#9834)

* Do not create a home directory.

* Re-add -m flag

* fix docker build (#9971)

* bump smallvec to 0.6 in ethcore-light, ethstore and whisper (#9588)

* bump smallvec to 0.6 in ethcore-light, ethstore and whisper

* bump transaction-pool

* Fix test.

* patch cargo to use tokio-proto from git repo

this makes sure we no longer depend on smallvec 0.2.1 which is
affected by servo/rust-smallvec#96

* use patched version of untrusted 0.5.1

* ci: allow audit to fail
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@debris @ordian @niklasad1 @5chdn @tomusdrw