This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Remove caching for osx tests. #9664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @ddorgan signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
ddorgan
added
F8-enhancement 🎊
5chdn
previously approved these changes
Sep 27, 2018
5chdn
added
A8-looksgood 🦄
|
Not looking great so far. Will need to re-test this with a new system to rule out this being an issue with the disks on our existing runners. |
5chdn
reviewed
Sep 30, 2018
| @@ -56,4 +56,4 @@ cd parity-clib-examples/cpp && \ | |||
| # Running tests | |||
| echo "________Running Parity Full Test Suite________" | |||
| git submodule update --init --recursive | |||
| time cargo test $OPTIONS --features "$FEATURES" --all $1 -- --test-threads 8 | |||
| time cargo test $OPTIONS --features "$FEATURES" --all $1 -- --test-threads 4 | |||
There was a problem hiding this comment.
I want to time this to check if the builds went faster. Right now the load average is about 16, which is double the amount of CPU's available. Was hoping reducing the amount of threads would cause less resource contention. But the times look about the same :/
|
Unfortunately, I think this does not solve any of our issues, also conflicts with #9681 |
5chdn
added
A5-grumble 🔥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some jobs are spending longer on caching than the actual running of tests, e.g. https://gitlab.parity.io/parity/parity-ethereum/-/jobs/101206