This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
CI: Remove unnecessary pipes #9681
Merged
Merged
Changes from 12 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
aa34dfa
ci: reduce gitlab pipelines significantly
5chdn 94cf19d
ci: build pipeline for PR
5chdn ff311d4
ci: remove dead weight
5chdn ffadc7f
ci: remove github release script
5chdn 32c812a
ci: remove forever broken aura tests
5chdn 42f3100
ci: add random stuff to the end of the pipes
5chdn 99e8652
ci: add wind and mac to the end of the pipe
5chdn bc3c111
ci: remove snap artifacts
5chdn e18270f
ci: (re)move dockerfiles
5chdn 88b6169
ci: clarify job names
5chdn 244528e
ci: add cargo audit job
5chdn ab9c371
ci: make audit script executable
5chdn 269d7c1
ci: ignore snap and docker files for rust check
5chdn f0f123c
ci: simplify audit script
5chdn 597bbfc
ci: rename misc to optional
5chdn d41e3bc
ci: add publish script to releaseable branches
5chdn 8eb65a9
ci: more verbose cp command for windows build
5chdn ab61722
ci: fix weird binary checksum logic in push script
5chdn a86d005
ci: fix regex in push script for windows
5chdn 0190876
ci: simplify gitlab caching
5chdn 9da093a
docs: align README with ci changes
5chdn 0e8263b
ci: specify default cargo target dir
5chdn e915d5d
ci: print verbose environment
5chdn 4da8e25
ci: proper naming of scripts
5chdn f4774c5
ci: restore docker files
5chdn 91d732f
ci: use docker hub file
5chdn a125169
ci: use cargo home instead of cargo target dir
5chdn 8e8cb9a
ci: touch random rust file to trigger real builds
5chdn 885aab6
ci: set cargo target dir for audit script
5chdn 778493a
ci: remove temp file
5chdn d890ab3
ci: don't export the cargo target dir in the audit script
5chdn a99c6a3
ci: fix windows unbound variable
5chdn 506842b
docs: fix gitlab badge path
5chdn da0f3cc
rename deprecated gitlab ci variables
gabreal f749b0e
ci: fix git compare for nightly builds
5chdn 0ababae
test: skip c++ example for all platforms but linux
5chdn b1f501a
Merge branch 'a5-gitlab-light' of github.com:paritytech/parity-ethere…
5chdn a02990e
ci: add random rust file to trigger tests
5chdn 4783af1
ci: remove random rust file
5chdn c146243
disable cpp lib test for mac, win and beta (#9686)
gabreal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/bin/bash | ||
|
||
set -e # fail on any error | ||
set -u # treat unset variables as error | ||
|
||
rustup default stable | ||
|
||
git submodule update --init --recursive | ||
|
||
rustup show | ||
cargo install cargo-audit | ||
cargo audit |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't really need submodules here
would be enough
Btw, is this job required or allowed to fail? Looks like you've removed all
allow_failure
s.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, for
cargo install
s it'd nice to specifyCARGO_TARGET_DIR
to enable caching (see https://github.com/jtgeibel/cargo/blob/a81b1437de95920618119272c7a92bab9974ee30/src/etc/man/cargo-install.1#L45-L47).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression we cache all jobs? see line 16 in .gitlab.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is at the end of the pipeline and can happily fail :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but it looks like we specify
CARGO_TARGET_DIR
only in wasm-tests?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we default to ./target everywhere and that should be cached per job name, just double-checked.