Sync endpoints before starting HTTP server #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP server which is used for CRUD and invocations should not be started until the cached informers for endpoints is ready. This may be related to issue #749 The cache sync duration is now being logged and measured for users to provide logs and additional information. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
|
@LucasRoesler I can't see the harm in adding this and cutting a release. @stefanprodan and @grampelberg helped with the suggestions based - there is more that can be done to optimise going forward, but that's already written up on the roadmap. |
|
I've cut a release so that the two users on the thread can try it out and give feedback. https://github.com/openfaas/faas-netes/releases/tag/0.12.16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Ellis (OpenFaaS Ltd) [email protected]
Description
Sync endpoints before starting HTTP server
Motivation and Context
The HTTP server which is used for CRUD and invocations should
not be started until the cached informers for endpoints is
ready. This may be related to issue #749
The cache sync duration is now being logged and measured for
users to provide logs and additional information.
How Has This Been Tested?
With several thousand pods and varying levels of replicas I was unable to reproduce a 404 error with the operator, using hey to generate traffic, and Prometheus to monitor status codes.
The following new logs are present in addition to the wait upon start-up:
When the wait statement was before the informers were started, the output read "Endpoints synced? true" and the sync returned immediately, so this seems to be making progress.
Types of changes