This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Enable basic-auth #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents the faas-swarm service from being accessed from functions within the overlay network. Tested with additional changes to the faas compose file to add the required secrets. Overhead is minimal. Tested on Swarm cluster. Signed-off-by: Alex Ellis (VMware) <[email protected]>
- This is a feature flag depending on the env-var "basic_auth" Signed-off-by: Alex Ellis (VMware) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the faas-swarm service from being accessed from
functions within the overlay network.
Tested with additional changes to the faas compose file to add
the required secrets. Overhead is minimal.
Tested on Swarm cluster.
Signed-off-by: Alex Ellis (VMware) [email protected]
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
git commit -s