This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Update secret handler for PUT method #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexellis
reviewed
Jan 6, 2020
handlers/secrets.go
Outdated
| } | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("not found secret with name: %s", name), http.StatusNotFound | ||
| return nil, http.StatusNotFound, fmt.Errorf("not found secret with name: %s", name) |
There was a problem hiding this comment.
unable to find secret with name: %s
alexellis
reviewed
Jan 6, 2020
handlers/secrets.go
Outdated
| @@ -51,7 +51,8 @@ func MakeSecretsHandler(c client.SecretAPIClient) http.HandlerFunc { | |||
| responseStatus, responseBody, responseErr = createNewSecret(c, body) | |||
| break | |||
| case http.MethodPut: | |||
| responseStatus, responseBody, responseErr = updateSecret(c, body) | |||
| responseStatus = http.StatusMethodNotAllowed | |||
| responseErr = fmt.Errorf("docker swarm secrets are immutable") | |||
There was a problem hiding this comment.
faas-swarm is unable to update secrets, delete and re-create or use a new name
There was a problem hiding this comment.
Please could you add a unit test for this scenario if we don't have one yet?
There was a problem hiding this comment.
We already had unit test for this scenario, I have updated it.
alexellis
suggested changes
Jan 6, 2020
This commit updates secrets handler for PUT method. It returns 405 "Method Not Allowed" for PUT method becuase secrets in docker swarm are immutable. Fixes: openfaas#65 Signed-off-by: Vivek Singh <[email protected]>
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates secrets handler for PUT method. It returns 405
"Method Not Allowed" for PUT method becuase secrets in docker swarm are
immutable.
Fixes: #65
Signed-off-by: Vivek Singh [email protected]
Description
Motivation and Context
#65
How Has This Been Tested?
I have tested this on Docker For Mac with Docker Swarm. For testing use
viveksyngh/faas-swarm:latest-devdocker image.Types of changes
Checklist:
git commit -s