Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow '/' and '.' in type and relation names #254

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bubianchi-criteo
Copy link

Description

In the FGA DSL, this change allows type and relations identifiers to contain / (slash) and . (dot) characters.
Moreover some restrictions are applied:

  • an identifier must start with a letter or an underscore
  • an identifier must end with a letter, an underscore or a digit
  • an identifier can not contain two consecutive slash, dot or minus

References

See discussion

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@bubianchi-criteo bubianchi-criteo requested a review from a team as a code owner May 16, 2024 14:48
Copy link

linux-foundation-easycla bot commented May 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bubianchi-criteo / name: Bruno Bianchi (272a33c)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant