Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: java syntax errors have wrong line base #331

Merged
merged 1 commit into from
Aug 28, 2024
Merged

fix: java syntax errors have wrong line base #331

merged 1 commit into from
Aug 28, 2024

Conversation

d-jeffery
Copy link
Contributor

@d-jeffery d-jeffery commented Aug 28, 2024 •
edited
Loading

Description

This bug when uncaught because it is a wrapped ANTLR error and the line & col number are not compared as part of the tests.

language/pkg/java/src/test/java/dev/openfga/language/ModelValidatorShould.java

Line 39 in 2663f80

// unfortunately antlr is throwing different error messages in Java, Go and JS - considering that at the moment

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery marked this pull request as ready for review August 28, 2024 21:48
@d-jeffery d-jeffery requested review from a team as code owners August 28, 2024 21:48
rhamzeh
rhamzeh approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to team: should ensure line/col numbers in tests

@d-jeffery d-jeffery added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit eb1335a Aug 28, 2024
11 checks passed
@d-jeffery d-jeffery deleted the fix/java-syntax-errors branch August 28, 2024 21:55
@rhamzeh rhamzeh mentioned this pull request Sep 6, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@ewanharris ewanharris Awaiting requested review from ewanharris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SyntaxError impl in Java is 1 based, instead of 0 based like other exceptions
2 participants
@d-jeffery @rhamzeh