Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of ListUsers excluded users #769

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Jun 13, 2024

Description

Removes all mentions of excluded_users in the context of the ListUsers API. This feature was originally a well-intentioned way to communicate any negations that may exist on public-typed wildcard (e.g. user:*) as a means of being abundantly clear about what a user:* result entails. However, as we discover more possible situations where excluded users could arise, we realize that we were making a premature decision about the API. We fully intend to re-add excluded_users at some point in the future but may or may not be a flattened list as previously implemented.

References

Removal from API: openfga/api#171

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@willvedd willvedd requested review from a team as code owners June 13, 2024 19:42
Copy link
Contributor

github-actions bot commented Jun 13, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://openfga.github.io/openfga.dev/pr-preview/pr-769/
on branch gh-pages at 2024-06-17 18:37 UTC

rhamzeh
rhamzeh previously approved these changes Jun 13, 2024
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a follow-up we can add the documentation to note this so that users are aware

rhamzeh
rhamzeh previously approved these changes Jun 14, 2024
jon-whit
jon-whit previously approved these changes Jun 14, 2024
rhamzeh
rhamzeh previously approved these changes Jun 17, 2024
rhamzeh added a commit that referenced this pull request Jun 17, 2024
the update is blocked by merging in #769 first
@rhamzeh
Copy link
Member

rhamzeh commented Jun 17, 2024

@willvedd can you update openfga/sdk to v0.5.0 as part of this? (not a requirement to merge)

@willvedd willvedd dismissed stale reviews from rhamzeh and jon-whit via 2c95891 June 17, 2024 18:35
package.json Show resolved Hide resolved
@willvedd willvedd merged commit 6f67ecf into main Jun 18, 2024
12 checks passed
@willvedd willvedd deleted the list-users-remove-excluded-users branch June 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants